Improve LWJGL wrong version error message#3527
Merged
douira merged 3 commits intoCaffeineMC:devfrom Mar 21, 2026
Merged
Conversation
jadeposting
reviewed
Feb 28, 2026
...on/src/boot/java/net/caffeinemc/mods/sodium/client/compatibility/checks/PreLaunchChecks.java
Outdated
Show resolved
Hide resolved
Member
|
Can you provide the context for these changes? |
Contributor
Author
|
Improves the advice message by attempting to figure out the culprit, pointing the user to the mod/launcher that caused it rather than sodium support. If the jar containing the LWJGL class is If the path contains If neither, we still put the name of the launcher in the error message to help with diagnosing the cause, even if we aren't sure that it is caused by the launcher. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the advice message by attempting to figure out the culprit, pointing the user to the mod/launcher that caused it rather than sodium support.
If the jar containing the LWJGL class is
/mods/*, then the advice says that it is likely caused by the mod.If the path contains
/lwjgl/, or the filename starts withlwjgl-, then it is likely that the jar is being provided by the launcher itself, so we direct the user to the launcher for support.If neither, we still put the name of the launcher in the error message to help with diagnosing the cause, even if we aren't sure that it is caused by the launcher.