Added _enumeration.range and *_default values to _restr_distance_min.F#26
Merged
nautolycus merged 3 commits intoCOMCIFS:mainfrom Jan 29, 2026
Merged
Added _enumeration.range and *_default values to _restr_distance_min.F#26nautolycus merged 3 commits intoCOMCIFS:mainfrom
nautolycus merged 3 commits intoCOMCIFS:mainfrom
Conversation
Collaborator
|
Looks good overall, but I think COMCIFS has taken a slightly stricter view towards default values in DDLm dictionaries. Specifically, default values should not be included unless: Source: https://www.iucr.org/__data/iucr/lists/coredmg/msg00461.html Does this default value fit within these suggestions? Happy to merge anyway, just noting this. |
vaitkus
approved these changes
Jan 27, 2026
Collaborator
Author
On reflection, the B and F parameters cause the overall equation to behave differently if they have a value of 0. I will remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.