Skip to content

Add 3D Splines (with periodic or greville boundary conditions) #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Add 3D Splines (with periodic or greville boundary conditions) #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c043b51
Add a 3D spline builder for the periodic case
tretre91 Sep 26, 2025
094bb64
Changes to the derivs domain
tretre91 Sep 29, 2025
ca308fc
Reword the FIXMEs in the 3D test
tretre91 Sep 30, 2025
abd8999
Fix a typo
tretre91 Sep 30, 2025
18531bb
Format the splines CMakeLists.txt
tretre91 Sep 30, 2025
fc04ba1
Add missing doc comments and add unused annotations to the derivs
tretre91 Sep 30, 2025
82e6333
Declare new header files to CMake
tpadioleau Sep 30, 2025
c0c7141
Increase timeout
tpadioleau Oct 1, 2025
ddc5110
Modify 3D error bound computation
tretre91 Oct 2, 2025
ec69b64
Use annotate_only in action-junit-report
tpadioleau Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/early_integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ jobs:
cxx_version: '23'
runs-on: ubuntu-latest
needs: [docker-build]
permissions:
checks: write # Required by mikepenz/action-junit-report
steps:
- name: Free Disk Space (Ubuntu)
uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be # v1.3.1
Expand Down Expand Up @@ -223,4 +221,5 @@ jobs:
uses: mikepenz/action-junit-report@3585e9575db828022551b4231f165eb59a0e74e3 # v5.6.2
if: ( success() || failure() ) && steps.test.outputs.with_report == 'true' # always run even if the previous step fails
with:
annotate_only: true # forked repo cannot write to checks so just do annotations
report_paths: '${{github.workspace}}/tests.xml'
3 changes: 1 addition & 2 deletions .github/workflows/tests-macos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ jobs:
CC: ${{matrix.backend.c_compiler}}
CXX: ${{matrix.backend.cxx_compiler}}
CMAKE_BUILD_TYPE: ${{matrix.cmake_build_type}}
permissions:
checks: write # Required by mikepenz/action-junit-report
steps:
- name: Checkout built branch
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
Expand Down Expand Up @@ -204,6 +202,7 @@ jobs:
uses: mikepenz/action-junit-report@3585e9575db828022551b4231f165eb59a0e74e3 # v5.6.2
if: ( success() || failure() ) # always run even if the previous step fails
with:
annotate_only: true # forked repo cannot write to checks so just do annotations
report_paths: '${{github.workspace}}/build/tests.xml'
- name: Run examples
run: |
Expand Down
10 changes: 4 additions & 6 deletions .github/workflows/tests-ubuntu.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,6 @@ jobs:
cxx_version: '23'
runs-on: ubuntu-latest
needs: [docker-build, id_repo]
permissions:
checks: write # Required by mikepenz/action-junit-report
steps:
- name: Free Disk Space (Ubuntu)
uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be # v1.3.1
Expand Down Expand Up @@ -347,7 +345,7 @@ jobs:
cmake --build build
if [ 'xcpu' = 'x${{matrix.backend.name}}' ]
then
ctest --test-dir build --output-on-failure --timeout 10 --output-junit tests.xml
ctest --test-dir build --output-on-failure --timeout 20 --output-junit tests.xml
cp build/tests.xml .
./build/examples/characteristics_advection
./build/examples/game_of_life
Expand Down Expand Up @@ -381,6 +379,7 @@ jobs:
uses: mikepenz/action-junit-report@3585e9575db828022551b4231f165eb59a0e74e3 # v5.6.2
if: ( success() || failure() ) && steps.test.outputs.with_report == 'true' # always run even if the previous step fails
with:
annotate_only: true # forked repo cannot write to checks so just do annotations
report_paths: '${{github.workspace}}/tests.xml'

test-with-sanitizer:
Expand All @@ -398,8 +397,6 @@ jobs:
sanitizer: ['address', 'undefined']
runs-on: ubuntu-latest
needs: [docker-build, id_repo]
permissions:
checks: write # Required by mikepenz/action-junit-report
steps:
- name: Free Disk Space (Ubuntu)
uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be # v1.3.1
Expand Down Expand Up @@ -457,7 +454,7 @@ jobs:
. /src/sanitizer_env.sh
fi

ctest --test-dir build --output-on-failure --timeout 10 --output-junit tests.xml
ctest --test-dir build --output-on-failure --timeout 20 --output-junit tests.xml
cp build/tests.xml .
./build/examples/characteristics_advection
./build/examples/game_of_life
Expand All @@ -483,6 +480,7 @@ jobs:
uses: mikepenz/action-junit-report@3585e9575db828022551b4231f165eb59a0e74e3 # v5.6.2
if: ( success() || failure() ) && steps.test.outputs.with_report == 'true' # always run even if the previous step fails
with:
annotate_only: true # forked repo cannot write to checks so just do annotations
report_paths: '${{github.workspace}}/tests.xml'

clang-tidy-test:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/tests-windows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ jobs:
Kokkos_ROOT: ${{github.workspace}}/opt/kokkos
GTest_ROOT: ${{github.workspace}}/opt/gtest
CMAKE_BUILD_PARALLEL_LEVEL: 4
permissions:
checks: write # Required by mikepenz/action-junit-report
steps:
- name: Checkout built branch
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
Expand Down Expand Up @@ -113,6 +111,7 @@ jobs:
uses: mikepenz/action-junit-report@3585e9575db828022551b4231f165eb59a0e74e3 # v5.6.2
if: ( success() || failure() ) # always run even if the previous step fails
with:
annotate_only: true # forked repo cannot write to checks so just do annotations
report_paths: '${{github.workspace}}/build/tests.xml'
- name: Run examples
shell: bash
Expand Down
2 changes: 2 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,8 +279,10 @@ if("${DDC_BUILD_KERNELS_SPLINES}")
include/ddc/kernels/splines/spline_boundary_conditions.hpp
include/ddc/kernels/splines/spline_builder.hpp
include/ddc/kernels/splines/spline_builder_2d.hpp
include/ddc/kernels/splines/spline_builder_3d.hpp
include/ddc/kernels/splines/spline_evaluator.hpp
include/ddc/kernels/splines/spline_evaluator_2d.hpp
include/ddc/kernels/splines/spline_evaluator_3d.hpp
include/ddc/kernels/splines/spline_traits.hpp
include/ddc/kernels/splines/splines_linear_problem.hpp
include/ddc/kernels/splines/splines_linear_problem_2x2_blocks.hpp
Expand Down
2 changes: 2 additions & 0 deletions include/ddc/kernels/splines.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@
#include "splines/spline_boundary_conditions.hpp"
#include "splines/spline_builder.hpp"
#include "splines/spline_builder_2d.hpp"
#include "splines/spline_builder_3d.hpp"
#include "splines/spline_evaluator.hpp"
#include "splines/spline_evaluator_2d.hpp"
#include "splines/spline_evaluator_3d.hpp"
#include "splines/spline_traits.hpp"
#include "splines/splines_linear_problem.hpp"
#include "splines/splines_linear_problem_2x2_blocks.hpp"
Expand Down
Loading