Add 3D Splines (with periodic or greville boundary conditions) #925
+4,250
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
==========================================
- Coverage 94.02% 91.88% -2.14%
==========================================
Files 55 57 +2
Lines 2727 2834 +107
Branches 853 925 +72
==========================================
+ Hits 2564 2604 +40
- Misses 87 136 +49
- Partials 76 94 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- rename some of the type aliases - use only one deriv dimension in the derivs_domain type aliases - enable the greville tests - lower the norm threshold for the triple derivative to 1e-10
tpadioleau
force-pushed
the
multid_splines
branch
from
6b2a589 to
3774590
Compare
tpadioleau
force-pushed
the
multid_splines
branch
from
3774590 to
ec69b64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
SplineBuilder3DandSplineEvaluator3Dclasses to handle 3D splines. Some 3D spline tests are also added.In its current state, Hermite boundary conditions are not handled. Also, the API for the SplineBuilder3D will certainly need to be modified (we currently take as arguments the derivatives on the faces and the cross derivatives on the corners, but we might also want the cross derivatives on the edges).