Leafref util functions #2352
Merged
Leafref util functions #2352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Brad House <[email protected]>
Meaning all leafrefs that target a specific node. Co-authored-by: Brad House <[email protected]>
Co-authored-by: Brad House <[email protected]>
michalvasko
force-pushed
the
leafrefs
branch
from
37030f8 to
2f373f8
Compare
|
thanks, at first glance this looks basically the same so it should work. I'll pull it into the SONiC PRs I've got so I can run the tests there to make sure all is good. I'll report back. Thanks! |
bradh352
added a commit
to bradh352/libyang-python
that referenced
this pull request
Feb 17, 2025
bradh352
added a commit
to bradh352/libyang-python
that referenced
this pull request
Feb 17, 2025
In libyang v1 the schema nodes had a backlinks member to be able to look up dependents of the node. SONiC depends on this to provide functionality it uses and it needs to be exposed via the python module. In theory, exposing the 'dfs' functions could make this work, but it would likely be cost prohibitive since walking the tree would be expensive to create a python node for evaluation in native python. Instead this PR depends on the this libyang PR: CESNET/libyang#2352 And adds thin wrappers. This implementation provides 2 python functions: * Context.find_backlinks_paths() - This function can take the path of the base node and find all dependents. If no path is specified, then it will return all nodes that contain a leafref reference. * Context.find_leafref_path_target_paths() - This function takes an xpath, then returns all target nodes the xpath may reference. Typically only one will be returned, but multiples may be in the case of a union. A user can build a cache by combining Context.find_backlinks_paths() with no path set and building a reverse table using Context.find_leafref_path_target_paths() Signed-off-by: Brad House <[email protected]>
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 17, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
|
@michalvasko I can confirm this PR passes our test cases in SONiC. Thanks! |
|
I'm not familiar with your process, but it appears the libyang-python repo depends on commits in the libyang |
|
The last release is still fairly new so it will likely be at least a few months. |
|
Ok, I'll need to try to push @rjarry I guess to make sure the changes will be acceptable or if there are any requested APi changes in libyang-python when using the new APIs as I'll need to pull in PRs into SONiC as patches before they are accepted. |
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 20, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 20, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 21, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 25, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 25, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 25, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 28, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 1, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 4, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 6, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 8, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 11, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 12, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 3, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 3, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 20, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/libyang-python
that referenced
this pull request
Apr 22, 2025
In libyang v1 the schema nodes had a backlinks member to be able to look up dependents of the node. SONiC depends on this to provide functionality it uses and it needs to be exposed via the python module. In theory, exposing the 'dfs' functions could make this work, but it would likely be cost prohibitive since walking the tree would be expensive to create a python node for evaluation in native python. Instead this PR depends on the this libyang PR: CESNET/libyang#2352 And adds thin wrappers. This implementation provides 2 python functions: * Context.find_backlinks_paths() - This function can take the path of the base node and find all dependents. If no path is specified, then it will return all nodes that contain a leafref reference. * Context.find_leafref_path_target_paths() - This function takes an xpath, then returns all target nodes the xpath may reference. Typically only one will be returned, but multiples may be in the case of a union. A user can build a cache by combining Context.find_backlinks_paths() with no path set and building a reverse table using Context.find_leafref_path_target_paths() Signed-off-by: Brad House <[email protected]>
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 22, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 24, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jun 13, 2025
CESNET/libyang#2352 Backlinks were removed between libyang1 and libyang2, this adds helper functions for enumerating backlinks.
bradh352
added a commit
to bradh352/libyang-python
that referenced
this pull request
Jun 13, 2025
In libyang v1 the schema nodes had a backlinks member to be able to look up dependents of the node. SONiC depends on this to provide functionality it uses and it needs to be exposed via the python module. In theory, exposing the 'dfs' functions could make this work, but it would likely be cost prohibitive since walking the tree would be expensive to create a python node for evaluation in native python. Instead this PR depends on the this libyang PR: CESNET/libyang#2352 And adds thin wrappers. This implementation provides 2 python functions: * Context.find_backlinks_paths() - This function can take the path of the base node and find all dependents. If no path is specified, then it will return all nodes that contain a leafref reference. * Context.find_leafref_path_target_paths() - This function takes an xpath, then returns all target nodes the xpath may reference. Typically only one will be returned, but multiples may be in the case of a union. A user can build a cache by combining Context.find_backlinks_paths() with no path set and building a reverse table using Context.find_leafref_path_target_paths() Signed-off-by: Brad House <[email protected]>
bradh352
added a commit
to bradh352/libyang-python
that referenced
this pull request
Jun 13, 2025
In libyang v1 the schema nodes had a backlinks member to be able to look up dependents of the node. SONiC depends on this to provide functionality it uses and it needs to be exposed via the python module. In theory, exposing the 'dfs' functions could make this work, but it would likely be cost prohibitive since walking the tree would be expensive to create a python node for evaluation in native python. Instead this PR depends on the this libyang PR: CESNET/libyang#2352 And adds thin wrappers. This implementation provides 2 python functions: * Context.find_backlinks_paths() - This function can take the path of the base node and find all dependents. If no path is specified, then it will return all nodes that contain a leafref reference. * Context.find_leafref_path_target_paths() - This function takes an xpath, then returns all target nodes the xpath may reference. Typically only one will be returned, but multiples may be in the case of a union. A user can build a cache by combining Context.find_backlinks_paths() with no path set and building a reverse table using Context.find_leafref_path_target_paths() Signed-off-by: Brad House <[email protected]>
bradh352
added a commit
to bradh352/libyang-python
that referenced
this pull request
Jun 13, 2025
In libyang v1 the schema nodes had a backlinks member to be able to look up dependents of the node. SONiC depends on this to provide functionality it uses and it needs to be exposed via the python module. In theory, exposing the 'dfs' functions could make this work, but it would likely be cost prohibitive since walking the tree would be expensive to create a python node for evaluation in native python. Instead this PR depends on the this libyang PR: CESNET/libyang#2352 And adds thin wrappers. This implementation provides 2 python functions: * Context.find_backlinks_paths() - This function can take the path of the base node and find all dependents. If no path is specified, then it will return all nodes that contain a leafref reference. * Context.find_leafref_path_target_paths() - This function takes an xpath, then returns all target nodes the xpath may reference. Typically only one will be returned, but multiples may be in the case of a union. A user can build a cache by combining Context.find_backlinks_paths() with no path set and building a reverse table using Context.find_leafref_path_target_paths() Signed-off-by: Brad House <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #2351