Skip to content

Bundle E2E coverage gates #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BASIC-BIT merged 4 commits into from
May 31, 2026
Merged

Bundle E2E coverage gates #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a39a92e
Expand E2E coverage bundle
BASIC-BIT May 31, 2026
c5b01a8
Gate hosted extended profile flow
BASIC-BIT May 31, 2026
f3fa2d8
Add PostHog infrastructure setup
BASIC-BIT May 31, 2026
1dd12fd
Address E2E review feedback
BASIC-BIT May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/baseline-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,9 @@ jobs:
PLAYWRIGHT_BASE_URL: ${{ vars.VRDEX_HOSTED_E2E_BASE_URL }}
PLAYWRIGHT_RECORD_VIDEO: "true"
PLAYWRIGHT_SKIP_WEBSERVERS: "true"
VRDEX_ENABLE_E2E_EXTENDED_PROFILE_FLOW: ${{ vars.VRDEX_HOSTED_E2E_EXTENDED_PROFILE_FLOW }}
VRDEX_ENABLE_E2E_AUTH_HELPERS: ${{ vars.VRDEX_HOSTED_E2E_AUTH_HELPERS }}
VRDEX_ENABLE_E2E_ADAPTER_HELPERS: ${{ vars.VRDEX_HOSTED_E2E_ADAPTER_HELPERS }}
VRDEX_E2E_BROWSER_TOKEN: ${{ secrets.VRDEX_HOSTED_E2E_BROWSER_TOKEN }}
VRDEX_E2E_RUN_ID: pr-${{ github.event.pull_request.number }}-${{ github.run_id }}-${{ github.run_attempt }}
run: pnpm test:e2e:hosted
Expand All @@ -404,6 +407,9 @@ jobs:
env:
HOSTED_OUTCOME: ${{ steps.hosted.outcome }}
HOSTED_BASE_URL: ${{ vars.VRDEX_HOSTED_E2E_BASE_URL }}
HOSTED_EXTENDED_PROFILE_FLOW: ${{ vars.VRDEX_HOSTED_E2E_EXTENDED_PROFILE_FLOW }}
HOSTED_AUTH_HELPERS: ${{ vars.VRDEX_HOSTED_E2E_AUTH_HELPERS }}
HOSTED_ADAPTER_HELPERS: ${{ vars.VRDEX_HOSTED_E2E_ADAPTER_HELPERS }}
RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
run: |
mkdir -p apps/web/playwright-artifacts
Expand All @@ -414,6 +420,12 @@ jobs:

Target: ${HOSTED_BASE_URL}

Hosted extended profile flow: ${HOSTED_EXTENDED_PROFILE_FLOW:-skipped}

Hosted auth helpers: ${HOSTED_AUTH_HELPERS:-skipped}

Hosted adapter helpers: ${HOSTED_ADAPTER_HELPERS:-skipped}

Captured flow:
- hosted test-gated profile submission form
- hosted Convex profile creation
Expand Down Expand Up @@ -443,6 +455,9 @@ jobs:
env:
HOSTED_OUTCOME: ${{ steps.hosted.outcome }}
HOSTED_BASE_URL: ${{ vars.VRDEX_HOSTED_E2E_BASE_URL }}
HOSTED_EXTENDED_PROFILE_FLOW: ${{ vars.VRDEX_HOSTED_E2E_EXTENDED_PROFILE_FLOW }}
HOSTED_AUTH_HELPERS: ${{ vars.VRDEX_HOSTED_E2E_AUTH_HELPERS }}
HOSTED_ADAPTER_HELPERS: ${{ vars.VRDEX_HOSTED_E2E_ADAPTER_HELPERS }}
ARTIFACT_URL: ${{ steps.upload.outputs.artifact-url }}
with:
script: |
Expand All @@ -454,6 +469,9 @@ jobs:
const artifactUrl = process.env.ARTIFACT_URL || "";
const outcome = process.env.HOSTED_OUTCOME || "unknown";
const target = process.env.HOSTED_BASE_URL || "not configured";
const extendedProfileFlow = process.env.HOSTED_EXTENDED_PROFILE_FLOW === "true" ? "enabled" : "skipped";
const authHelpers = process.env.HOSTED_AUTH_HELPERS === "true" ? "enabled" : "skipped";
const adapterHelpers = process.env.HOSTED_ADAPTER_HELPERS === "true" ? "enabled" : "skipped";
const artifactLine = artifactUrl
? `Artifact: [playwright-hosted-data-flow](${artifactUrl})`
: "Artifact: not generated";
Expand All @@ -462,6 +480,9 @@ jobs:
"## Playwright Hosted Data-Flow",
`Outcome: ${outcome}`,
`Target: ${target}`,
`Hosted extended profile flow: ${extendedProfileFlow}`,
`Hosted auth helpers: ${authHelpers}`,
`Hosted adapter helpers: ${adapterHelpers}`,
`Run: ${runUrl}`,
artifactLine,
"",
Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/deployed-health.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ jobs:
PLAYWRIGHT_BASE_URL: ${{ steps.gate.outputs.base_url }}
PLAYWRIGHT_RECORD_VIDEO: "true"
PLAYWRIGHT_SKIP_WEBSERVERS: "true"
VRDEX_ENABLE_E2E_EXTENDED_PROFILE_FLOW: ${{ vars.VRDEX_HOSTED_E2E_EXTENDED_PROFILE_FLOW }}
VRDEX_ENABLE_E2E_AUTH_HELPERS: ${{ vars.VRDEX_HOSTED_E2E_AUTH_HELPERS }}
VRDEX_ENABLE_E2E_ADAPTER_HELPERS: ${{ vars.VRDEX_HOSTED_E2E_ADAPTER_HELPERS }}
VRDEX_E2E_BROWSER_TOKEN: ${{ secrets.VRDEX_HOSTED_E2E_BROWSER_TOKEN }}
VRDEX_E2E_RUN_ID: deployed-${{ github.run_id }}-${{ github.run_attempt }}
run: pnpm test:e2e:hosted
Expand All @@ -100,6 +103,9 @@ jobs:
env:
HOSTED_OUTCOME: ${{ steps.hosted.outcome }}
HOSTED_BASE_URL: ${{ steps.gate.outputs.base_url }}
HOSTED_EXTENDED_PROFILE_FLOW: ${{ vars.VRDEX_HOSTED_E2E_EXTENDED_PROFILE_FLOW }}
HOSTED_AUTH_HELPERS: ${{ vars.VRDEX_HOSTED_E2E_AUTH_HELPERS }}
HOSTED_ADAPTER_HELPERS: ${{ vars.VRDEX_HOSTED_E2E_ADAPTER_HELPERS }}
RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
run: |
mkdir -p apps/web/playwright-artifacts
Expand All @@ -110,6 +116,12 @@ jobs:

Target: ${HOSTED_BASE_URL}

Hosted extended profile flow: ${HOSTED_EXTENDED_PROFILE_FLOW:-skipped}

Hosted auth helpers: ${HOSTED_AUTH_HELPERS:-skipped}

Hosted adapter helpers: ${HOSTED_ADAPTER_HELPERS:-skipped}

Captured flow:
- hosted test-gated profile submission form
- hosted Convex profile creation
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/staging-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ jobs:
PLAYWRIGHT_BASE_URL: ${{ steps.gate.outputs.hosted_base_url }}
PLAYWRIGHT_RECORD_VIDEO: "true"
PLAYWRIGHT_SKIP_WEBSERVERS: "true"
VRDEX_ENABLE_E2E_EXTENDED_PROFILE_FLOW: ${{ vars.VRDEX_HOSTED_E2E_EXTENDED_PROFILE_FLOW }}
VRDEX_ENABLE_E2E_AUTH_HELPERS: ${{ vars.VRDEX_HOSTED_E2E_AUTH_HELPERS }}
VRDEX_ENABLE_E2E_ADAPTER_HELPERS: ${{ vars.VRDEX_HOSTED_E2E_ADAPTER_HELPERS }}
VRDEX_E2E_BROWSER_TOKEN: ${{ secrets.VRDEX_HOSTED_E2E_BROWSER_TOKEN }}
VRDEX_E2E_RUN_ID: staging-deploy-${{ github.run_id }}-${{ github.run_attempt }}
run: pnpm test:e2e:hosted
Expand Down
5 changes: 3 additions & 2 deletions apps/web/.env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@ NEXT_PUBLIC_CONVEX_URL=
# Set true in Vercel if previews must fail when NEXT_PUBLIC_CONVEX_URL is missing.
VRDEX_REQUIRE_CONVEX_URL=false

# Optional PostHog analytics. Missing values keep analytics disabled.
# Optional PostHog analytics. Missing key keeps analytics disabled.
# BASIC BIT hosted deployments use PostHog project 447783, managed through infra/terraform/vercel.
NEXT_PUBLIC_POSTHOG_KEY=
NEXT_PUBLIC_POSTHOG_HOST=
NEXT_PUBLIC_POSTHOG_HOST=https://us.i.posthog.com

# Convex Auth OAuth providers.
AUTH_DISCORD_ID=
Expand Down
Loading
Loading