Bundle E2E coverage gates#110
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Playwright Hosted Data-FlowOutcome: success This optional check runs the mutation-backed profile flow against a configured hosted dev/staging target with isolated E2E test data. |
Playwright Data-Flow PreviewOutcome: success Captured flow:
Artifacts include screenshots, traces, and recorded video for the flow run. |
Playwright Image DiffOutcome: success Changed screenshot baselines: none in this PR. This check compares public route screenshots against committed baselines. Inline images show only added or modified baseline PNGs. |
Playwright Public Screenshot PreviewOutcome: success Screenshots: all public route checks passed on desktop and mobile. Full screenshot set is available in the artifact. Pixel diff baselines are handled by the separate Playwright Image Diff check. |
Greptile SummaryThis PR bundles three new E2E coverage slices — profile field-visibility, community admin verification via Discord, and VRChat/VRCLinking proof-code claims — along with local adapter stubs that let Convex claim actions run end-to-end without real external API calls. All hosted paths remain opt-in via repository variables and are skipped by default until staging is explicitly configured.
Confidence Score: 4/5Safe to merge; all new adapter routes are gated behind multiple opt-in flags and blocked from production builds. The adapter stubs and extended-profile helper are well-guarded and opt-in by default. The two findings are both in the new E2E test file: the VRCLinking claim section skips the intermediate proof-code visibility assertion that the parallel VRChat block includes, and optionalText is called twice per field in the Convex mutation. Neither affects production behaviour, but the missing assertion could let a silent failure in the create-proof step go undetected during a test run. apps/web/e2e/auth-claim.flow.spec.ts — the VRCLinking proof block is missing the intermediate VRDEX- code assertion present in the VRChat block directly above it. Important Files Changed
|
What changed
447783and the import/apply path.Why
Refs #100. This bundles the next E2E/deployment slices without enabling production mutation helpers or requiring real Discord, VRChat, VRCLinking, or SES calls in CI, and records the new VRDex PostHog project setup in checked-in infrastructure.
Verification
pnpm --filter web lintpnpm --filter web typecheckpnpm typecheck:backendpnpm verify:backend:localpnpm test:backend@flowPlaywright run on desktop Chromiumpnpm test:e2ehttps://staging.vrdex.netreturned1 skippedfor the extended profile field-visibility flow while the repo opt-in variable is unsetpnpm --filter web check:vercel-envterraform fmt -check -recursive infra/terraformterraform validateininfra/terraform/posthogterraform validateininfra/terraform/vercelgit diff --checkRisk notes
VERCEL_TOKENis added as a GitHub secret.