Add Tags to SubOrchestrationInstanceCreatedEvent #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the Tags property to the SubOrchestrationInstanceCreatedEvent history event class to support rewind operations in the DTS backend. The Tags dictionary is needed to reconstruct ExecutionStartedEvent instances when sub-orchestrations have been purged before a rewind.
- Added
Tagsproperty toSubOrchestrationInstanceCreatedEventclass with appropriate documentation and serialization attributes - Refactored tag merging in
TaskOrchestrationDispatcher.csto compute merged tags once and assign to both the history event and execution started event - Updated the abridged event generation to preserve the Tags property
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/DurableTask.Core/History/SubOrchestrationInstanceCreatedEvent.cs | Added Tags property with DataMember attribute and updated copy constructor to include Tags |
| src/DurableTask.Core/TaskOrchestrationDispatcher.cs | Refactored to compute mergedTags once and assign to both SubOrchestrationInstanceCreatedEvent and ExecutionStartedEvent |
| src/DurableTask.Core/OrchestrationRuntimeState.cs | Updated abridged event generation to preserve Tags property |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
This PR might be a good chance to add the warning that we discussed earlier: #1264 |
sophiatev
reviewed
Dec 23, 2025
Collaborator
Author
I think you can just merge the latter, I approved it. |
sophiatev
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the history event for creating suborchestration did not record the
Tagsdictionary. This creates challenges for the rewind implementation in the DTS backend, since it uses this history event to reconstruct the ExecutionStartedEvent in cases where a suborchestration was purged prior to a rewind.