Validate version before running static validation #4470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* static validation depends on cluster version * if unset, static validation can't complete * and results in a SKU invalid error.
ArrisLee
requested review from
bennerv,
fahlmant,
hawkowl,
hlipsig,
jharrington22,
kimorris27,
mociarain,
mrWinston,
pepedocs,
rogbas,
sankur-codes,
tiguelu,
tsatam,
wanghaoran1988 and
yjst2012
as code owners
Tof1973
force-pushed
the
populate-version-before-static-validation
branch
5 times, most recently
from
7397493 to
b811eea
Compare
Tof1973
force-pushed
the
populate-version-before-static-validation
branch
4 times, most recently
from
c330374 to
bc4cd90
Compare
Collaborator
|
In E2E test, when FE starts and cluster creation is done immediately, we reach the validateInsallVersion before OCP versions are initialized. This was not an issue before as validation was done after ValidateNewCluster which takes few seconds, but now we need to do it before and so we need to make sure OCP versions are already initialized. |
Tof1973
force-pushed
the
populate-version-before-static-validation
branch
from
255cc9c to
66fd098
Compare
Collaborator
|
The current fix has been tested in local dev and E2E and it is working and fixing the issue in local dev. |
mociarain
approved these changes
Nov 26, 2025
Member
mociarain
left a comment
mociarain
left a comment
There was a problem hiding this comment.
LGTM. Left a question that's not blocking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes #itn-2025-00300
What this PR does / why we need it:
Version validation populates the version if not specified by the user, so we need to run it before we do static validation so that static validation can determine if the SKU is valid or not.
Better error handling when:
--verisonparam when there is no default ocp version availableTest plan for issue: