make sure default version is set before validating cluster

Author: Tof1973

pkg/frontend/changefeed.go

@@ -5,6 +5,7 @@ package frontend
 
 import (
 	"context"
+	"net/http"
 	"time"
 
 	"github.com/Azure/ARO-RP/pkg/api"
@@ -118,6 +119,23 @@ func (f *frontend) updateOcpVersions(docs []*api.OpenShiftVersionDocument) {
 	}
 }
 
+func (f *frontend) waitOcpVersionsInitialized() error {
+	timeout := time.After(80 * time.Second)
+	ticker := time.NewTicker(500 * time.Millisecond)
+	defer ticker.Stop()
+
+	for f.lastOcpVersionsChangefeed.Load() == nil {
+		f.baseLog.Infof("OCP versions not yet initialized, waiting for it...")
+		select {
+		case <-ticker.C:
+		case <-timeout:
+			f.baseLog.Error("Server do not have initialized OCP version within timeout")
+			return api.NewCloudError(http.StatusInternalServerError, api.CloudErrorCodeInternalServerError, "properties.clusterProfile.version", "No OpenShift version list defined on server side.")
+		}
+	}
+	return nil
+}
+
 func (f *frontend) updateFromIteratorRoleSets(ctx context.Context, ticker *time.Ticker, frontendIterator cosmosdb.PlatformWorkloadIdentityRoleSetDocumentIterator) {
 	for {
 		successful := true

pkg/frontend/openshiftcluster_putorpatch.go

@@ -256,6 +256,7 @@ func (f *frontend) _putOrPatchOpenShiftCluster(ctx context.Context, log *logrus.
 		if err != nil {
 			return nil, err
 		}
+		ext = putOrPatchClusterParameters.converter.ToExternal(doc.OpenShiftCluster)
 
 		err = f.ValidateNewCluster(ctx, subscription, doc.OpenShiftCluster, putOrPatchClusterParameters.staticValidator, ext, putOrPatchClusterParameters.path)
 		if err != nil {

pkg/frontend/validate.go

@@ -231,6 +231,9 @@ func validateAdminMasterVMSize(vmSize string) error {
 // validateInstallVersion validates the install version set in the clusterprofile.version
 // TODO convert this into static validation instead of this receiver function in the validation for frontend.
 func (f *frontend) validateInstallVersion(ctx context.Context, oc *api.OpenShiftCluster) error {
+	if err := f.waitOcpVersionsInitialized(); err != nil {
+		return err
+	}
 	f.ocpVersionsMu.RLock()
 	defer f.ocpVersionsMu.RUnlock()