-
Notifications
You must be signed in to change notification settings - Fork 41
Enable Playground CLI feature flag by default #1692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f46eb68
c9b3858
0ec34c5
10c2f9a
a647130
22b0763
99f06a2
aa0fa2b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -106,8 +106,6 @@ const config: ForgeConfig = { | |
// By default the dev server uses the same port as calypso.localhost | ||
port: 3456, | ||
} ), | ||
// This plugin bundles the externals defined in the Webpack config file. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's add comment about - "why do we need it, in our case?", instead of "What does it do?". There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry I don't get it fully, this comment was removed, so where should we add this explanation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, it was removed, not added, sorry 😅 |
||
new ForgeExternalsPlugin( { externals: Object.keys( mainBaseConfig.externals ?? {} ) } ), | ||
], | ||
hooks: { | ||
generateAssets: async () => { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks weird. So sometimes when we run test we get 200 and sometimes 302?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my testing I received only 302 which is about the content being temporarily moved. I added both here for robustness, as I think the WP frontend can respond either one.