Skip to content

Enable Playground CLI feature flag by default #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

wojtekn
Copy link
Contributor

@wojtekn wojtekn commented Aug 19, 2025

Related issues

Proposed Changes

  • I propose to enable the Playground CLI feature flag by default and fix the code to actually support the default value.

Testing Instructions

  1. Start Studio by running npm start
  2. Confirm that Blueprints feature flag is enabled by default
  3. Confirm flag can be disables so wp-now can be used

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@wojtekn wojtekn requested a review from a team August 19, 2025 07:52
@wojtekn wojtekn self-assigned this Aug 19, 2025
Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good and making the feature flag enabled by default works as expected. The feature flag can still be disabled. 👌🏼

Looks like we just need to adjust the unit tests a little bit.

@wojtekn
Copy link
Contributor Author

wojtekn commented Aug 19, 2025

Looks like we just need to adjust the unit tests a little bit.

Actually, does it look like tests were not updated to cover the blueprint project's 'Add site' flow changes?

@ivan-ottinger
Copy link
Contributor

Actually, does it look like tests were not updated to cover the blueprint project's 'Add site' flow changes?

Yes, this seems to be the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants