Skip to content

Fix: Resolve CS8618 nullable warnings in SOAP response classes #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petre-c merged 2 commits into from
Aug 4, 2025
Merged

Fix: Resolve CS8618 nullable warnings in SOAP response classes #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
515c52f
fix: Resolve CS8618 nullable warnings in SOAP response classes
Aug 4, 2025
d1a4ce3
fix: Add nullable and required modifiers to AccountMovement properties
Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion AppifySheets.TBC.IntegrationService.Client.Core.sln.DotSettings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=TBC/@EntryIndexedValue">TBC</s:String></wpf:ResourceDictionary>
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=TBC/@EntryIndexedValue">TBC</s:String>
<s:Boolean x:Key="/Default/UserDictionary/Words/=appify/@EntryIndexedValue">True</s:Boolean></wpf:ResourceDictionary>
60 changes: 30 additions & 30 deletions ...ionService.Client/SoapInfrastructure/GetAccountMovements/GetAccountMovementsResponseIo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public class Pager
[XmlRoot(ElementName = "result")]
public class ResultXml
{
[XmlElement(ElementName = "pager")] public Pager Pager { get; init; }
[XmlElement(ElementName = "pager")] public required Pager Pager { get; init; }

[XmlElement(ElementName = "totalCount")]
public int TotalCount { get; init; }
Expand All @@ -26,91 +26,91 @@ public class ResultXml
public class AmountT
{
[XmlElement(ElementName = "amount")] public decimal Amount { get; init; }
[XmlElement(ElementName = "currency")] public string Currency { get; init; }
[XmlElement(ElementName = "currency")] public required string Currency { get; init; }
}

[XmlRoot(ElementName = "accountMovement")]
public class AccountMovement
{
[XmlElement(ElementName = "movementId")]
public string MovementId { get; init; }
public required string MovementId { get; init; }

[XmlElement(ElementName = "externalPaymentId")]
public string ExternalPaymentId { get; init; }
public string? ExternalPaymentId { get; init; }

[XmlElement(ElementName = "debitCredit")]
public string DebitCredit { get; init; }
public required string DebitCredit { get; init; }

[XmlElement(ElementName = "valueDate")]
public DateTime ValueDate { get; init; }

[XmlElement(ElementName = "description")]
public string Description { get; init; }
public required string Description { get; init; }

[XmlElement(ElementName = "amount")] public AmountT Amount { get; init; }
[XmlElement(ElementName = "amount")] public required AmountT Amount { get; init; }

[XmlElement(ElementName = "accountNumber")]
public string AccountNumber { get; init; }
public string? AccountNumber { get; init; }

[XmlElement(ElementName = "accountName")]
public string AccountName { get; init; }
public string? AccountName { get; init; }

[XmlElement(ElementName = "additionalInformation")]
public string AdditionalInformation { get; init; }
public string? AdditionalInformation { get; init; }

[XmlElement(ElementName = "documentDate")]
public string DocumentDate { get; init; }
public string? DocumentDate { get; init; }

[XmlElement(ElementName = "documentNumber")]
public string DocumentNumber { get; init; }
public string? DocumentNumber { get; init; }

[XmlElement(ElementName = "partnerAccountNumber")]
public string PartnerAccountNumber { get; init; }
public string? PartnerAccountNumber { get; init; }

[XmlElement(ElementName = "partnerName")]
public string PartnerName { get; init; }
public string? PartnerName { get; init; }

[XmlElement(ElementName = "partnerTaxCode")]
public string PartnerTaxCode { get; init; }
public string? PartnerTaxCode { get; init; }

[XmlElement(ElementName = "partnerBankCode")]
public string PartnerBankCode { get; init; }
public string? PartnerBankCode { get; init; }

[XmlElement(ElementName = "partnerBank")]
public string PartnerBank { get; init; }
public string? PartnerBank { get; init; }

[XmlElement(ElementName = "taxpayerCode")]
public string TaxpayerCode { get; init; }
public string? TaxpayerCode { get; init; }

[XmlElement(ElementName = "taxpayerName")]
public string TaxpayerName { get; init; }
public string? TaxpayerName { get; init; }

[XmlElement(ElementName = "operationCode")]
public string OperationCode { get; init; }
public string? OperationCode { get; init; }

[XmlElement(ElementName = "partnerDocumentType")]
public string PartnerDocumentType { get; init; }
public string? PartnerDocumentType { get; init; }

[XmlElement(ElementName = "statusCode")]
public string StatusCode { get; init; }
public string? StatusCode { get; init; }

[XmlElement(ElementName = "transactionType")]
public string TransactionType { get; init; }
public string? TransactionType { get; init; }

[XmlElement(ElementName = "additionalDescription")]
public string AdditionalDescription { get; init; }
public string? AdditionalDescription { get; init; }

[XmlElement(ElementName = "partnerPersonalNumber")]
public string PartnerPersonalNumber { get; init; }
public string? PartnerPersonalNumber { get; init; }

[XmlElement(ElementName = "partnerDocumentNumber")]
public string PartnerDocumentNumber { get; init; }
public string? PartnerDocumentNumber { get; init; }

[XmlElement(ElementName = "paymentId")]
public string PaymentId { get; init; }
public string? PaymentId { get; init; }

[XmlElement(ElementName = "parentExternalPaymentId")]
public string ParentExternalPaymentId { get; init; }
public string? ParentExternalPaymentId { get; init; }
}

[XmlRoot(ElementName = "GetAccountMovementsResponseIo")]
Expand All @@ -119,8 +119,8 @@ public class GetAccountMovementsResponseIo : ISoapResponse
[XmlElement(ElementName = "result")] public ResultXml? ResultXml { get; init; }

[XmlElement(ElementName = "accountMovement")]
public List<AccountMovement>? AccountMovement { get; init; }
public List<AccountMovement> AccountMovement { get; init; } = [];

[XmlAttribute(AttributeName = "ns2", Namespace = "http://www.w3.org/2000/xmlns/")]
public string Ns2 { get; init; }
public string? Ns2 { get; init; }
}
3 changes: 1 addition & 2 deletions ...Service.Client/SoapInfrastructure/GetPaymentOrderStatus/GetPaymentOrderStatusRequestIo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
namespace AppifySheets.TBC.IntegrationService.Client.SoapInfrastructure.GetPaymentOrderStatus;

[UsedImplicitly]
public record GetPaymentOrderStatusRequestIo(int SinglePaymentId)
: RequestSoap<GetPaymentOrderStatusResponseIo>
public record GetPaymentOrderStatusRequestIo(int SinglePaymentId) : RequestSoap<GetPaymentOrderStatusResponseIo>
{
public override string SoapXml()
=> $"""
Expand Down
2 changes: 1 addition & 1 deletion ...ervice.Client/SoapInfrastructure/GetPaymentOrderStatus/GetPaymentOrderStatusResponseIo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class GetPaymentOrderStatusResponseIo : ISoapResponse
{

[XmlElement(ElementName="status")]
public string Status { get; init; }
public string? Status { get; init; }

public PaymentStatusEnum PaymentStatus => Status switch
{
Expand Down
2 changes: 0 additions & 2 deletions ...Client/SoapInfrastructure/ImportSinglePaymentOrders/ImportSinglePaymentOrdersRequestIo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ public override string SoapXml()

public static class UseExtensions
{
public static TY Use<T, TY>(this T t, Func<T, TY> tTy) => tTy(t);

public static string FormatXml(this string xml)
{
try
Expand Down
10 changes: 0 additions & 10 deletions ...tionService.Client/SoapInfrastructure/ImportSinglePaymentOrders/TransferTypeInterfaces.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,6 @@ public abstract record TransferTypeRecord
public string? AdditionalDescription => TransferTypeRecordSpecific.AdditionalDescription;
}

// public interface IDescription
// {
// public string? Description { get; }
// }

// public interface IAdditionalDescription
// {
// public string? AdditionalDescription { get; }
// }

public interface IBeneficiaryName
{
public string BeneficiaryName { get; }
Expand Down
2 changes: 1 addition & 1 deletion ...grationService.Client/SoapInfrastructure/ImportSinglePaymentOrders/TransferTypeRecords.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ public record TransferToOtherBankNationalCurrencyPaymentOrderIo(BankAccountWithC
public record TreasuryTransferPaymentOrderIo(long TreasuryCode) : TransferTypeRecord, ITreasury;

[UsedImplicitly]
public record TransferToOwnAccountPaymentOrderIo(BankAccountWithCurrencyV RecipientAccountWithCurrency, string Description) : TransferTypeRecord, IRecipient, IBeneficiaryName, IDescription;
public record TransferToOwnAccountPaymentOrderIo(BankAccountWithCurrencyV RecipientAccountWithCurrency) : TransferTypeRecord, IRecipient, IBeneficiaryName, IDescription;
21 changes: 11 additions & 10 deletions ...rationService.Client/SoapInfrastructure/PasswordChangeRelated/ChangePasswordResponseIo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,43 +6,44 @@
// }

using System.Xml.Serialization;
using AppifySheets.TBC.IntegrationService.Client.SoapInfrastructure;

namespace AppifySheets.TBC.IntegrationService.Client.SoapInfrastructure.PasswordChangeRelated;

[XmlRoot(ElementName="ChangePasswordResponseIo")]
public class ChangePasswordResponseIo : ISoapResponse {

[XmlElement(ElementName="message")]
public string Message { get; set; }
public string? Message { get; init; }

[XmlAttribute(AttributeName="i")]
public string I { get; set; }
public string? I { get; init; }

[XmlText]
public string Text { get; set; }
public string? Text { get; init; }
}

[XmlRoot(ElementName="Body")]
public class Body {

[XmlElement(ElementName="ChangePasswordResponseIo")]
public ChangePasswordResponseIo ChangePasswordResponseIo { get; set; }
public ChangePasswordResponseIo? ChangePasswordResponseIo { get; init; }
}

[XmlRoot(ElementName="Envelope")]
public class Envelope {

[XmlElement(ElementName="Header")]
public object Header { get; set; }
public object? Header { get; init; }

[XmlElement(ElementName="Body")]
public Body Body { get; set; }
public required Body Body { get; init; }

[XmlAttribute(AttributeName="SOAP-ENV")]
public string SOAPENV { get; set; }
public string? SOAPENV { get; init; }

[XmlAttribute(AttributeName="ns2")]
public string Ns2 { get; set; }
public string? Ns2 { get; init; }

[XmlText]
public string Text { get; set; }
public string? Text { get; init; }
}
26 changes: 13 additions & 13 deletions ...egrationService.Client/SoapInfrastructure/PostboxMessages/GetPostboxMessagesResponseIo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,45 +14,45 @@
public class AdditionalAttributes {

[XmlElement(ElementName="name")]
public string Name { get; set; }
public required string Name { get; init; }

[XmlElement(ElementName="value")]
public DateTime Value { get; set; }
public DateTime Value { get; init; }
}

[XmlRoot(ElementName="messages")]
public class Messages {

[XmlElement(ElementName="messageId")]
public int MessageId { get; set; }
public int MessageId { get; init; }

[XmlElement(ElementName="messageText")]
public string MessageText { get; set; }
public required string MessageText { get; init; }

[XmlElement(ElementName="messageType")]
public string MessageType { get; set; }
public required string MessageType { get; init; }

[XmlElement(ElementName="messageStatus")]
public string MessageStatus { get; set; }
public required string MessageStatus { get; init; }

[XmlElement(ElementName="additionalAttributes")]
public List<AdditionalAttributes> AdditionalAttributes { get; set; }
public List<AdditionalAttributes>? AdditionalAttributes { get; init; }
}

[XmlRoot(ElementName="GetPostboxMessagesResponseIo")]
public class GetPostboxMessagesResponseIo : ISoapResponse {

[XmlElement(ElementName="messages")]
public List<Messages> Messages { get; set; }
public List<Messages>? Messages { get; init; }

[XmlAttribute(AttributeName="xsi")]
public string Xsi { get; set; }
public string? Xsi { get; init; }

[XmlAttribute(AttributeName="xsd")]
public string Xsd { get; set; }
public string? Xsd { get; init; }

[XmlText]
public string Text { get; set; }
public string? Text { get; init; }
}

[XmlRoot(ElementName="Root")]
Expand All @@ -62,8 +62,8 @@ public class Root {
public GetPostboxMessagesResponseIo? GetPostboxMessagesResponseIo { get; set; }

[XmlAttribute(AttributeName="ns2")]
public string Ns2 { get; set; }
public string? Ns2 { get; init; }

[XmlText]
public string Text { get; set; }
public string? Text { get; init; }
}
2 changes: 1 addition & 1 deletion AppifySheets.TBC.IntegrationService.Client/TBC_Services/Extensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ static object XmlDeserializeFromString(this string objectData, Type type)
var serializer = new XmlSerializer(type);

using TextReader reader = new StringReader(objectData);
var result = serializer.Deserialize(reader);
var result = serializer.Deserialize(reader)!;

return result;
}
Expand Down
Loading