Fix: Resolve CS8618 nullable warnings in SOAP response classes#13
Merged
Fix: Resolve CS8618 nullable warnings in SOAP response classes#13
Conversation
added 2 commits
August 4, 2025 23:17
- Changed properties from 'set' to 'init' for immutability - Added 'required' modifier for properties that are always present in responses - Made optional properties nullable with '?' modifier - Fixed warnings in ChangePasswordResponseIo and GetPostboxMessagesResponseIo *Collaboration by Claude*
- Made core movement properties required (movementId, debitCredit, description, amount) - Made optional properties nullable (partner info, taxpayer info, additional details) - Ensures proper handling of SOAP responses with missing optional fields *Collaboration by Claude*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setto immutableinitpropertiesChanges
settoinitfor immutabilityrequiredmodifier for properties that are always present in SOAP responses?modifierTest Plan
Collaboration by Claude