Update the code block for fip mapper - #488
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the FIP mapper to hard-code the name of the FIP acquisition repo instead of the experimental orchestration repo for VR/FIP,
Aind.Experiment.VrForaging-Fip.Hardcodes
code.nameas "aind-physiology-fip"Hardcodes
code.urlas "https://github.com/AllenNeuralDynamics/Aind.Physiology.Fip"Sets
code.versionasrig.versionfrom the FIP extracted metadata (here). This is theaind-physiology-fippackage versionSets code.parameters as
session.allow_dirty_repo(example. If true, this tells us that the acquisition code is not guaranteed to match the release version.No longer uses
session.commit_hash, since that's the HEAD of the deployment repo the launcher runs from (Aind.Experiment.VrForaging-Fip) rather than the acquisition control software itself.The resulting
Codeentry on the FIP data stream will look like this:{ "url": "https://github.com/AllenNeuralDynamics/Aind.Physiology.Fip", "name": "aind-physiology-fip", "version": "0.3.1-rc2", "parameters": {"allow_dirty_repo": true} }closes #418