Skip to content

Fix NULL dereference in global motion setup with frame resize #5350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
urvangjoshi merged 1 commit into from
Aug 31, 2026
+7 −3
Merged

Fix NULL dereference in global motion setup with frame resize #5350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions av2/encoder/global_motion_facade.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,11 +285,15 @@ static AVM_INLINE void update_valid_ref_frames_for_gm(
(ref_disabled && cpi->sf.hl_sf.recode_loop != DISALLOW_RECODE)) {
continue;
} else {
// Get the scaled buffer
if (av2_is_scaled(get_ref_scale_factors(cm, frame)))
// Get the scaled buffer. av2_scale_references() leaves scaled_ref_buf[]
// NULL for a disabled reference, which the check above can let through,
// so skip rather than dereference NULL.
if (av2_is_scaled(get_ref_scale_factors(cm, frame))) {
if (cpi->scaled_ref_buf[frame] == NULL) continue;
ref_buf[frame] = &cpi->scaled_ref_buf[frame]->buf;
else
} else {
ref_buf[frame] = &buf->buf;
}
}

int prune_ref_frames =
Expand Down