Fix NULL dereference in global motion setup with frame resize - #5350
Merged
Conversation
urvangjoshi
approved these changes
Aug 31, 2026
update_valid_ref_frames_for_gm() dereferenced cpi->scaled_ref_buf[frame] without checking it, but av2_scale_references() leaves that entry NULL for a disabled reference, and the skip-invalid-refs check only skips disabled references when recode is allowed. Under frame resize at speed >= 6 that combination occurs and the encoder segfaults on the first inter frame. Add the missing NULL check.
urvangjoshi
force-pushed
the
mr/avm-bugfix5
branch
from
August 31, 2026 16:01
2ecea3c to
72c76d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update_valid_ref_frames_for_gm() dereferenced cpi->scaled_ref_buf[frame] without checking it, but av2_scale_references() leaves that entry NULL for a disabled reference, and the skip-invalid-refs check only skips disabled references when recode is allowed. Under frame resize at speed >= 6 that combination occurs and the encoder segfaults on the first inter frame. Add the missing NULL check.
Fix issue #5348.