Skip to content

Add French and Japanese locales #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 29, 2021
Merged

Add French and Japanese locales #136

merged 9 commits into from
Mar 29, 2021

Conversation

doamatto
Copy link
Contributor

Extension of #123.

Resolves #61.
Resolves #39.
Resolves #5.

@doamatto doamatto changed the title Add french locales Add French locales Mar 10, 2021
@doamatto doamatto mentioned this pull request Mar 10, 2021
9 tasks
@doamatto doamatto changed the title Add French locales Add French and Japanese locales Mar 10, 2021
@doamatto doamatto marked this pull request as ready for review March 12, 2021 16:04
Copy link

@yazgazan yazgazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some typos in the French translations.

Feel free to ignore the ones you disagree with.

Co-authored-by: Guillaume de Sagazan <[email protected]>
@Genora51
Copy link
Member

Ok, I'm happy to merge this now

@Genora51 Genora51 merged commit 70deb4b into 8values:localization Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants