added persisted object injection#118
Open
tmol wants to merge 1 commit intozzzprojects:developfrom
tmol:master
Open
added persisted object injection#118tmol wants to merge 1 commit intozzzprojects:developfrom tmol:master
tmol wants to merge 1 commit intozzzprojects:developfrom
tmol:master
Conversation
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys,
I am working on an enterprise project where the main entity is very complex, quite few OwnedCollections in other OwnedCollections etc.The first update takes around 10 second using GraphDiff because of loading the entity in the GraphDiffer.Merge method. After the query compilation, the query is cached by EF but only for that specific entity with that specific key, if another entity is updated, the first update takes again 10 seconds.
I extended DbContextExtensions with another method where the already loaded entity can be provided, this way the LoadEntity is skipped and only the Merge happens:
public static T UpdateGraph(this DbContext context, T entity, T persisted, Expression<Func<IUpdateConfiguration, object>> mapping) where T : class
If you will accept the pull request, I will create the necessary unit tests and then notify you for merge.
I think that too many parameters are passed around in the DbContextExtensions UpdateGraph methods overloads, maybe a parameter class would be helpful there.
Cheers,
Tibi