Complete oh-my-pi agent adapter (supersedes #119)#130
Merged
Conversation
Register Oh My Pi as a new agent adapter writing config to `.omp/mcp.json`. Includes detection in the init wizard, smoke test coverage, docs update, and GCX default-format recognition for the `omp-coding-agent` client ID.
Add the missing agent-render drift-fence golden for the oh-my-pi adapter so TestAgentsRenderGolden passes, correct the adapter count in docs/agents.md to match the seventeen registered adapters, and sort the ohmypi import in cmd/gortex/init.go.
Bump the four adapter-count references to seventeen and add Oh My Pi to the supported-agents list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the Oh My Pi (
oh-my-pi) agent adapter from #119 and gets it green on CI. The adapter, format negotiation (omp-coding-agent→ GCX1), CLI/wizard registration, smoke test, and docs are all carried over from #119 (rebased onto currentmain); this branch adds the missing pieces that were causing CI to fail.What was failing on #119
Both
skill-driftand thetestmatrix failed on the same cause:A new adapter must ship its agent-render drift-fence golden; #119 didn't include one.
Changes on top of #119
cmd/gortex/testdata/agent-render/oh-my-pi.txt— the render golden for the new adapter (generated withgo test ./cmd/gortex -run TestAgentsRenderGolden -update-agent-render; only this golden is created, no other adapter drifts).docs/agents.md— there are now seventeen registered adapters (the prose was already off by one onmain, which said "Fifteen" with sixteen adapters).ohmypiimport incmd/gortex/init.go—gofmtordering.The two original commits from #119 are preserved with their authorship.
Verification
go test ./cmd/gortex— 372 pass (incl.TestAgentsRenderGolden, wire-contract golden)go test ./internal/agents/...— 160 passgo test ./internal/mcp -run TestDefaultFormatForClient— passgo build ./cmd/gortex,go vet,gofmt -l,golangci-lint run(changed pkgs) — all cleanSupersedes #119.