This repository was archived by the owner on Jun 5, 2018. It is now read-only.
RFD: Reuse existing paginator? #19
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #18 describes how pagination, especially paginator.num_pages breaks if
{% autopaginate %} is called twice in the same template.
I do not understand how the render method works, at least for now, but my troubles
seem to go away, at least for now, if I re-use the existing paginator the other time
around.
Most likely this is the intended behavior originally and not having it so was a bug,
but I can't say for sure.
Apparently there is no state magick involved, so this should be ok from a
thread-safety point of view.
Do you think think it's ok? I'd hate to break it for everyone else.