Skip to content

Conversation

Varun-Kolanu
Copy link
Contributor

Fixes #230.

Previous logic fetched all contributors in the repo and checked whether the commenter is a contributor or not.
The present logic fetches the commits of the commenter directly in the repo and checks whether they are contributor by verifying that number of commits are atleast one.

@Varun-Kolanu Varun-Kolanu force-pushed the claim-issues-bug branch 9 times, most recently from ecb550b to cf5756f Compare April 10, 2025 18:32
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.37%. Comparing base (3655e1f) to head (644223a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   64.25%   64.37%   +0.12%     
==========================================
  Files          23       23              
  Lines        1757     1763       +6     
==========================================
+ Hits         1129     1135       +6     
  Misses        628      628              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Varun-Kolanu
Copy link
Contributor Author

@laurynmm Could you please review when free?

@timabbott
Copy link
Member

This does seem like better logic -- certainly a much cheaper query. How have you tested it?

@Varun-Kolanu
Copy link
Contributor Author

Thanks!

Yeah, I tested it by setting up the bot locally using the Smee client and trying the feature on a test repo. When claiming with a username that had more than one commit, the fetch result correctly showed only one commit, and the issue was assigned as expected. And, when I used another username with no commits, the issue wasn't assigned.

@timabbott timabbott merged commit 7dc7e37 into zulip:main Apr 12, 2025
4 checks passed
@timabbott
Copy link
Member

Merged, thanks @Varun-Kolanu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contributors still limited when claiming issues when repository has a large number of contributors.
3 participants