Adjust the window size for desired client area and fix build error on Windows 11#39
Open
ZeunO8 wants to merge 7 commits intozserge:mainfrom
Open
Adjust the window size for desired client area and fix build error on Windows 11#39ZeunO8 wants to merge 7 commits intozserge:mainfrom
ZeunO8 wants to merge 7 commits intozserge:mainfrom
Conversation
ZeunO8
changed the title
ZeunO8
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that when opening a window on Windows the client area was smaller than the passed width/height.
Also when building I was getting an error about cannot convert HGDIOBJ to HBITMAP. I added a static_cast to resolve this
This commit corrects these two issues. (Tested and working)