Display oids in same format as ZODB.utils.oid_repr #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the representation of persistent object OIDs to follow the same format as ZODB’s oid_repr. The changes include adding a new test for short, odd-length OIDs in Python, introducing an oid_repr helper in Python to format OIDs, updating the C implementation to apply similar zero-padding logic, and documenting the change in CHANGES.rst.
- Added test case test_short_odd_oid in tests.
- Created Python helper function oid_repr for OID formatting.
- Updated C code in cPersistence.c to mirror the Python zero-padding behavior.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/persistent/tests/test_persistence.py | Added test to validate short OID representation |
| src/persistent/persistence.py | Introduced oid_repr function for OID formatting |
| src/persistent/cPersistence.c | Updated C implementation to apply zero-padding |
| CHANGES.rst | Documented the oid_repr formatting update |
dataflake
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #219