Repository navigation
Conversation
A fresh resolve of Gemfile.ractorize picks prism 2 now that minitest 6.1 no longer caps it. refract 1.1.0, which Phlex loads, references Prism::MissingNode, which prism 2 removed, so a Phlex app's ractorize job failed at boot. The cap is added to the repo's own prism requirement, or declared when the repo has none, until refract releases yippee-fun/refract#4 (yippee-fun/refract#6). Claude-Session: https://claude.ai/code/session_01E7i6yCPUYAKuVY9xXuKLf6
mhenrixon
added
bug
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Bundler 2.6.5 to 2.7 add a gemspec's development dependencies without calling +gem+, so the cap never saw them and the final `gem "prism", "< 2"` replaced the dev dependency, dropping its own requirement (Ruby 3.4.11 CI: ["< 2"] instead of [">= 1.4", "< 2"]). The cap now carries the requirement already declared for the gem. Claude-Session: https://claude.ai/code/session_01E7i6yCPUYAKuVY9xXuKLf6
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A fresh resolve of
Gemfile.ractorizenow picks prism 2.1.0, because minitest 6.1 no longer caps prism below 2. refract 1.1.0, which Phlex loads, referencesPrism::MissingNode, which prism 2 removed. So the ractorize job of any Phlex app fails at boot, beforeractorize!runs:The fix is merged in refract (yippee-fun/refract#4) but not released yet; yippee-fun/refract#6 asks for the release.
config/ractorize.gemfilecaps prism at< 2. The cap is added to the repo's own prism requirement, including a gemspec development dependency, or declared when the repo has none. Remove it once refract ships docs: install from RubyGems now that 0.1.0 is released #4.Consumers get the cap when they bump to the release that ships it:
conformance.ymlcopies the gemfile from the kit in the repo's lockfile.Test plan
spec/conformance_kit/ractorize_gemfile_spec.rb: three new examples (no prism line, a Gemfile prism line, a gemspec dev dependency), all seen failing before the change; the two existing examples now expectprismtoo.bundle exec rake: 246 examples, 0 failures, 18 pending; RuboCop clean. Spec file also green on Ruby 3.2.8.bundle exec conformance-kit check --ractorize:boot failed: NameError: uninitialized constant Prism::MissingNodeboot: ok, thenractorize!stops at the Rails main proc that rails/rails#59805 fixeshttps://claude.ai/code/session_01E7i6yCPUYAKuVY9xXuKLf6
Summary by cubic
Fixes ractorize jobs failing at boot for Phlex apps by capping prism below 2 in
config/ractorize.gemfile.A fresh resolve now picks prism 2.1.0 since minitest 6.1 no longer caps it, and refract 1.1.0 references
Prism::MissingNode, which prism 2 removed. The cap is added to the repo's own prism requirement (Gemfile line or gemspec development dependency) or declared when the repo has none, and carries that requirement so Bundler 2.6.5+ does not drop a gemspec's own prism floor. Remove the cap once refract releases yippee-fun/refract#4. README and CHANGELOG document the cap.Written for commit 15d72ed. Summary will update on new commits.