Fix links, add CI workflows #113
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
qmonnet
commented
Nov 20, 2024
qmonnet
commented
- package.json: Update dependencies
- ci: Add CI workflows
- readme.md: Fix (some) broken links
Let's use up-to-date linters and link checkers. Signed-off-by: Quentin Monnet <[email protected]>
Reuse the configuration we have for remark to create two CI workflows: - One runs on Pull Requests to make sure that the formatting of the README.md file remains OK. - The other one runs manually, to check that all links are still valid. We could make it run as a cron job, but to be honest that would just waste resources because it's useless if nobody checks the results periodically to clean up invalid links. Signed-off-by: Quentin Monnet <[email protected]>
Let's fix the links that are not longer valid. When possible, update with the new link; otherwise, remove the associated entry. After this change, the link checker still stumbles on a few links, but they are valid in the browser, and I see no obvious way to fix them. I suspect some CDNs reject bots or automated link checks and we're hitting this. Signed-off-by: Quentin Monnet <[email protected]>
Collaborator
Author
|
@zoidyzoidzoid Would you mind enabling GitHub Actions on the repo, please? |
Collaborator
Author
|
@zoidyzoidzoid It would be nice to have the checks run in CI. Any chance you can enable the Actions please (or give me permissions to do so, if you prefer)? |
Collaborator
Author
|
ping @zoidyzoidzoid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.