Remove dynamic RapidSnark linkage (use static instead)#11
Open
ElusAegis wants to merge 1 commit intozkmopro:mainfrom
Open
Remove dynamic RapidSnark linkage (use static instead)#11ElusAegis wants to merge 1 commit intozkmopro:mainfrom
ElusAegis wants to merge 1 commit intozkmopro:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: Enable running UniFFI tests for the mopro templates reliably. Dynamic
dyliblinkage was redundant and caused rpath/loader issues that block the UniFFI tests.Change: Drop the dynamic
rapidsnark(and related) linkage on desktop. Keep static linkage everywhere. If needed in some specific circumstances, we may provide an optional, feature-enabled switch to re-enable dynamic linking if needed.Impact: