Can I use custom pipeline instead of default  #715

Activity

1. zio

   locked and limited conversation to collaborators on Dec 29, 2021
2. amitksingh1490

   converted this issue into a discussion #717 on Dec 29, 2021
3. amitksingh1490

   reopened this on Dec 29, 2021
4. zio

   unlocked this conversation on Dec 29, 2021
5. rajcspsg commented on Dec 29, 2021

   

   rajcspsg

   on Dec 29, 2021

   Last edited by tusharmath

   ContributorAuthor

   More actions

   Let me add more details to this issue -

   the client can send requests in payload compressed based on the content-encoding header. For example, if the contents are compressed in gzipped format, then the content-encoding header would be gzip. Netty provides HttpContentDecompressor channel handler for this feature.

   Similarly the server can also send response in compressed format based on the Accept-Encoding header in the request. For this Netty provides HttpContentCompressor channelHandler for this feature.

   I've an example here. The code is on github here. you can run the project by using gradle just-netty:runMain to run the server. The example of client to call the server is here

   try(CloseableHttpClient httpclient = HttpClients.createDefault()) {
           HttpPost httppost = new HttpPost("http://localhost:5880/test");
           String payload = "{ \"test\" : 1 }";
           EntityBuilder builder = EntityBuilder.create().gzipCompress().setContentEncoding("gzip").chunked().setText(payload);
           HttpEntity entity = builder.build();
           httppost.setEntity(entity);
           System.out.println();
           httppost.setHeader("Accept-Encoding", "gzip,deflate");
           httppost.setHeader("Content-Encoding", "gzip");
           System.out.println("Executing request: " + httppost.getRequestLine());
           CloseableHttpResponse response = httpclient.execute(httppost);
           try {
               System.out.println("----------------------------------------");
               System.out.println(response.getStatusLine());
               System.out.println(EntityUtils.toString(response.getEntity()));
           } finally {
               response.close();
           }
       }

   In my current organization we use HttpContentCompressor and HttpContentDecompressor in our server and also has some additional handler in pipeline.

   IMHO, zio-http should allow users to provide option for defining custom HttpPipeline. In cases if the users didn't provide additional pipeline , then Server.make should use default pipeline.

   Please let me know if I'm not clear in this problem description.
6. tusharmath commented on Jan 20, 2022

   

   tusharmath

   on Jan 20, 2022

   Collaborator

   More actions

   This seems like something we should have in ZIO Http.
7. tusharmath

   added

   enhancementNew feature or requestNew feature or request

   on Jan 20, 2022
8. tusharmath

   closed this as completedin #932on Feb 20, 2022