loongarch: Scaffold self-hosted LoongArch backend #24182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a weird AIR construction. I am just doing what the x86-64 backend is doing.
alexrp
reviewed
Jun 14, 2025
xtexx
changed the title
alexrp
reviewed
Jun 15, 2025
| @@ -0,0 +1,790 @@ | |||
| //! Inline assembly parser for LoongArch. | |||
There was a problem hiding this comment.
Also should rename this directory.
alexrp
reviewed
Jun 15, 2025
| @@ -91,6 +94,7 @@ pub fn legalizeFeatures(pt: Zcu.PerThread, nav_index: InternPool.Nav.Index) ?*co | |||
| pub const AnyMir = union { | |||
| aarch64: @import("arch/aarch64/Mir.zig"), | |||
| arm: @import("arch/arm/Mir.zig"), | |||
| loongarch64: @import("arch/loongarch64/Mir.zig"), | |||
There was a problem hiding this comment.
Suggested change
| loongarch64: @import("arch/loongarch64/Mir.zig"), | |
| loongarch: @import("arch/loongarch/Mir.zig"), |
alexrp
reviewed
Jun 15, 2025
| @@ -102,6 +106,7 @@ pub const AnyMir = union { | |||
| return switch (backend) { | |||
| .stage2_aarch64 => "aarch64", | |||
| .stage2_arm => "arm", | |||
| .stage2_loongarch => "loongarch64", | |||
There was a problem hiding this comment.
Suggested change
| .stage2_loongarch => "loongarch64", | |
| .stage2_loongarch => "loongarch", |
alexrp
reviewed
Jun 15, 2025
| @@ -44,6 +44,10 @@ pub const Env = enum { | |||
| /// - `zig build-* -fno-llvm -fno-lld -target wasm32-* --listen=-` | |||
| wasm, | |||
|
|
|||
| /// - sema | |||
| /// - `zig build-* -fincremental -fno-llvm -fno-lld -target loongarch64-linux --listen=-` | |||
There was a problem hiding this comment.
Suggested change
| /// - `zig build-* -fincremental -fno-llvm -fno-lld -target loongarch64-linux --listen=-` | |
| /// - `zig build-* -fincremental -fno-llvm -fno-lld -target loongarch(32,64)-linux --listen=-` |
alexrp
reviewed
Jun 15, 2025
| @@ -0,0 +1,514 @@ | |||
| const std = @import("std"); | |||
alexrp
reviewed
Jun 15, 2025
| @@ -4128,7 +4128,7 @@ pub fn getTarget(self: Elf) std.Target { | |||
| fn requiresThunks(self: Elf) bool { | |||
| return switch (self.getTarget().cpu.arch) { | |||
| .aarch64 => true, | |||
| .x86_64, .riscv64 => false, | |||
| .x86_64, .riscv64, .loongarch64 => false, | |||
There was a problem hiding this comment.
Worth checking if all the added linker code is actually 64-bit only; I suspect not?
|
No, it also generates encoders for LA32(S/R). Thank you for looking into this PR. I will rename this file next weekend as soon as I am available.
|
|
cc @jacobly0 to review the general structure of the new backend. |
|
You might want to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a self-hosted LoongArch64 backend.
The backend currently implements only a few features.
Test runner is working, but due to the very limited number of passing behavior tests, the backend is not added to the test target list.
Although it is foreseeable that I will not have much time to work on this backend in the coming one year due to my study, I will try to keep the backend working and expand its features.