compiler: test runner: fix tests never fails on crippled architectures #24180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Rexicon226 |
|
I've had a message from @Rexicon226 with feedback -- he's currently not able to reply on here, so this comment is just me relaying that feedback :P He says that this PR is correct and overall fine to merge, but that the printing needs to be disabled (I'm guessing to avoid spamming the CI logs, which I would agree with). Looks like that would just require reverting the |
xtexx
force-pushed
the
riscv64-tests
branch
3 times, most recently
from
20a607f to
989f05b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously tests for stage2 RISC-V 64 backend are never failing. This PR fixes it and skips all currently failing rv64 behavior tests.