Refactor fragment container creation with MyLuaFileManager#299
Open
Refactor fragment container creation with MyLuaFileManager#299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MaterialCardViewso the two containers can be displayed side-by-side (parallel) or overlapping on thefghost depending on screen width (inSekai).Description
mods/MyLuaFileManager.luawhich programmatically creates twoMaterialCardViewwrappers containingFrameLayouthosts and exposesnew,getContainerPair,setParallelMode,selectTargetContainer,markContainer, andinitDefaultTagsAPIs.app/src/main/assets_bin/home.luatorequire "mods.MyLuaFileManager", instantiate the manager withMyLuaFileManager.new(fg), obtainf1,f2viagetContainerPair(), callsetParallelModeon layout changes, and initialize tags withinitDefaultTags().app/src/main/assets_bin/layout/fragment.alysofgis now a dedicated horizontal host for the manager to populate instead of containing staticf1/f2frames.app/src/main/assets_bin/mods/muk.luato prefermyLuaFileManagerfor selecting and marking the target container inMyLuaFileFragment.onDestroyandnewActivity, while keeping the original logic as a fallback when the manager is not present.Testing
git diff --checkwhich completed without issues.Codex Task