vertexfilter: Fix encodeFilterOct bit limit to start at K=2 #991
+11
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K=1 was never valid, as Z must encode 1.0f as a signed K-bit integer, and K=1 can only encode -1 and 0. Valid encodings must start at K=2. Also update documentation for other filters to specify ranges during encoding, and omit the precise range for decode functions to reduce redundancy.
bits=1 was never a valid configuration because it can't encode Z=1.
Adjust and correct bit count limits for various filters to make the documented values match native/JS checks and actually valid bit encodings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
K=1 was never valid, as Z must encode 1.0f as a signed K-bit integer,
and K=1 can only encode -1 and 0. Valid encodings must start at K=2.
Also update documentation for other filters to specify ranges during
encoding, and omit the precise range for decode functions to reduce
redundancy. After these updates, the documented and validated bit
counts should match the upcoming glTF KHR_meshopt_compression
specification (1+ for exponential, 2+ for octahedral and color, 4+ for
quaternion).