Merge useful changes by Andrzej Pieńkowski#2
Open
zeuner wants to merge 3 commits into
Open
Conversation
Add chatcommands, disable student priv
|
Kein Problem damit. |
Owner
Author
|
Gut, danke.
Originalnachricht:
… Kein Problem damit.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#2 (comment)
|
Owner
Author
|
The "student" privilege is now being split out: [1]. Das "student"-Privileg wird nun ausgelagert: [1]. [1] https://github.com/zeuner/edutest-chatcommands/tree/privilege-modularization |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to discuss merging these changes into the initial EDUtest codebase since a common, compatible codebase should benefit all users, and the changes seem to be fit well into the usage scenarios I know of. In particular:
"teacher" privilege renaming: It was controversial anyway since not all education-related contexts are school-based.
"student" privilege removal: It's not needed anyway since in the usual education-related scenarios, everyone who is not a "teacher" will be a "student". Furthermore, future versions will support bulk commands on "student" groups, which cannot be implemented well using privileges.
"heal" and "announce" commands: Seem generally useful.
Ich wuerde gerne eine Diskussion anstossen, ob diese Aenderungen in die urspruengliche EDUtest-Code-Basis aufgenommen werden sollten. Ich denke, es spricht einiges dafuer, da eine gemeinsame, kompatible Code-Basis allen Nutzern zugutekommen duerfte, und da die Aenderungen dort, wo EDUtest meines Wissens genutzt wird, meines Erachtens gut hineinpassen.
Umbenennung des "teacher"-Privilegs: Die Bezeichnung war ohnehin kontrovers, da nicht jeder paedagogische Kontext mit Schulen zusammenhaengt.
Entfernung des "student"-Privilegs: Es ist ohnehin nicht notwendig, da ueblicherweise jeder, der nicht "teacher" ist, "student" ist. Darueber hinaus wird in der Zukunft Unterstuetzung fuer Massenkommandos auf Schuelergruppen implementiert, was ohnehin nicht gut mit Privilegien umzusetzen ist.
Kommandos "heal" und "announce": Scheinen mir allgemein nuetzlich zu sein.