-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Support single arch builds on macOS #2435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
7f8a73c
to
bfccc1a
Compare
I can't test right now but I'll say I sometimes comment out one of the architectures when I'm iterating because it's much faster to compile only one native arch. Would be cool to have if it doesn't break something in our build systems. |
bfccc1a
to
8f56d48
Compare
Should be no change in the behavior, however your use case becomes easier by applying make flags. |
@laduke any chance you could take a look again at this PR? |
Looking at this one before a release -- is there a reason this is important? AFAIK multi-arch macOS binaries only load the target arch and the binary is not large. |
the OP says something about their downstream package system. |
8f56d48
to
141520b
Compare
I've rebased the code on top of the latest changes The main benefit for this one is being able to optionally build single architecture builds, this is necessary in Nixpkgs as we only support building one architecture at a time. Nixpkgs is the package set for Nix the package manager which can build and install ZeroTier on both macOS and Linux |
This is useful for building ZeroTier in Nixpkgs as we only want to build one architecture at once