Skip to content

Support single arch builds on macOS #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Enzime
Copy link

@Enzime Enzime commented Feb 10, 2025

This is useful for building ZeroTier in Nixpkgs as we only want to build one architecture at once

@laduke
Copy link
Contributor

laduke commented Feb 10, 2025

I can't test right now but I'll say I sometimes comment out one of the architectures when I'm iterating because it's much faster to compile only one native arch. Would be cool to have if it doesn't break something in our build systems.

@Enzime Enzime requested a review from Mic92 February 11, 2025 04:04
@Mic92
Copy link
Contributor

Mic92 commented Feb 11, 2025

I can't test right now but I'll say I sometimes comment out one of the architectures when I'm iterating because it's much faster to compile only one native arch. Would be cool to have if it doesn't break something in our build systems.

Should be no change in the behavior, however your use case becomes easier by applying make flags.

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2025

CLA assistant check
All committers have signed the CLA.

@Enzime
Copy link
Author

Enzime commented Mar 2, 2025

@laduke any chance you could take a look again at this PR?

@adamierymenko
Copy link
Contributor

Looking at this one before a release -- is there a reason this is important? AFAIK multi-arch macOS binaries only load the target arch and the binary is not large.

@laduke
Copy link
Contributor

laduke commented Jul 14, 2025

the OP says something about their downstream package system.
local compile times being twice as fast when iterating would be good for me.

@Enzime Enzime force-pushed the push-yktvmzlpkktn branch from 8f56d48 to 141520b Compare July 15, 2025 01:29
@Enzime
Copy link
Author

Enzime commented Jul 15, 2025

I've rebased the code on top of the latest changes

The main benefit for this one is being able to optionally build single architecture builds, this is necessary in Nixpkgs as we only support building one architecture at a time.

Nixpkgs is the package set for Nix the package manager which can build and install ZeroTier on both macOS and Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants