Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates packaging metadata and build scripts for the 3.8.1-1 release to address Debian/Lintian upload requirements and remove obsolete Debian packaging for ice2slice.
Changes:
- Fix RPM major/minor version macros and package naming from 3.9 → 3.8.
- Update Debian packaging: rename build profile from
no-python312→nopython, adjust dependencies/metadata, and remove thezeroc-ice-ice2slicebinary package. - Repackaging guidance: exclude Gradle wrapper artifacts from the upstream tarball and update related Debian docs/scripts.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packaging/rpm/ice.spec | Corrects mmversion to 3.8 for RPM naming/sonames. |
| packaging/rpm/README | Updates RPM runtime package name to libice3.8-c++. |
| packaging/deb/debian/zeroc-ice-ice2slice.lintian-overrides | Removes Lintian overrides for deleted ice2slice Debian package. |
| packaging/deb/debian/zeroc-ice-ice2slice.install | Removes install manifest for deleted ice2slice Debian package. |
| packaging/deb/debian/rules | Switches build profile gate to nopython for Python packaging steps. |
| packaging/deb/debian/copyright | Documents repackaging and updates a Java file path reference. |
| packaging/deb/debian/control | Updates build profiles/deps, bumps Standards-Version, adds Rules-Requires-Root: no, removes ice2slice package stanza. |
| packaging/deb/debian/changelog | Updates the 3.8.1-1 entry timestamp. |
| packaging/deb/debian/README | Removes zeroc-ice-ice2slice from the Debian package list. |
| packaging/deb/debian/BUILDING.md | Updates repack/build instructions (excludes Gradle wrapper; uses nopython). |
| packaging/deb/build-package.sh | Updates CI build script to create a repacked orig tarball with exclusions and proper prefix. |
| .github/workflows/build-deb-packages.yml | Updates Debian 12 builds to use DEB_BUILD_PROFILES=nopython. |
packaging/deb/debian/copyright
Outdated
| Source: https://github.com/zeroc-ice/ | ||
| Comment: Repackaged to remove pre-built Java binaries (gradle-wrapper.jar) and | ||
| files not needed for the Debian build. | ||
| Files-Excluded: */gradle/GRADLE_LICENSE */gradle/wrapper */gradlew* cpp/src/IceUtil/ConvertUTF.* |
There was a problem hiding this comment.
Files-Excluded lists */gradle/wrapper, but the repackaging notes/scripts exclude */gradle/wrapper/* (to drop gradle-wrapper.jar). As written, */gradle/wrapper doesn’t match files under that directory, so the gradle wrapper artifacts may still be included when tools rely on Files-Excluded (e.g., repacks based on this metadata). Update Files-Excluded to exclude the wrapper contents (e.g., */gradle/wrapper/* or the specific jar/properties files) so it matches the documented intent.
Suggested change
| Files-Excluded: */gradle/GRADLE_LICENSE */gradle/wrapper */gradlew* cpp/src/IceUtil/ConvertUTF.* | |
| Files-Excluded: */gradle/GRADLE_LICENSE */gradle/wrapper/* */gradlew* cpp/src/IceUtil/ConvertUTF.* |
- Install systemd services to /usr/lib/systemd/system/ (aliased-location) - Fix mismatched lintian overrides by removing specific context - Remove obsolete syslog.target from systemd service files - Update debian/watch to version 5 - Add Origin field to quilt patch referencing upstream commit - Add missing copyright attributions for Bison Grammar.cpp, docfx CSS, and third-party license documentation files - Exclude packaging/rpm/ from Debian orig tarball - Add Priority, Rules-Requires-Root, remove redundant Section fields
These languages and platforms are not built as Debian packages. Excluding them simplifies the copyright file and reduces tarball size.
Backport fix for "specifed" -> "specified" typo in icegriddb and icestormdb man pages from upstream commit 88dd46c.
- Exclude js/* from orig tarball (not built for Debian) - Add Grammar.h to Bison copyright stanza (same license as Grammar.cpp) - Expand unicode test glob to cover LICENSE file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix lintian errors reported on the mentors.debian.net upload for the 3.8.1-1 Debian package.
nopythonbuild profile instead of customno-python312${binary:Version}to${source:Version}for arch:all package dependencieskfreebsdarch restrictions from Build-DependsStandards-Versionto 4.7.3 and addRules-Requires-Root: noSimpleInternalFrame.javapath indebian/copyrightdebian/copyrightSectionfield fromzeroc-ice-slicepackageFiles-Excludedfiles from orig tarball viagit archivepathspecszeroc-ice-ice2slicepackage and add quilt patch to exclude it from the build(>=)dependencies inzeroc-ice-compilerstransitional packageBUILDING.mdand CI workflow with new profile name