You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix invalid pointer-to-integer cast and comparison warnings in ADXL362, ADXL367, and ADXL372 decoder drivers. The previous code used (uint8_t *)*fit for offset comparison, which triggered -Wint-to-pointer-cast warnings on recent compilers and could lead to undefined behavior.
This patch replaces unsafe casts with uintptr_t arithmetic and ensures type-safe offset calculations, preserving existing logic while eliminating all build warnings.
Hello @Dilip-Raman, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊
Fix invalid pointer-to-integer cast and comparison warnings in
ADXL362, ADXL367, and ADXL372 decoder drivers. The previous code
used `(uint8_t *)*fit` for offset comparison, which triggered
`-Wint-to-pointer-cast` warnings on recent compilers and could
lead to undefined behavior.
This patch replaces unsafe casts with `uintptr_t` arithmetic and
ensures type-safe offset calculations, preserving existing logic
while eliminating all build warnings.
Signed-off-by: Dilip Raman <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dilip-Raman
force-pushed
the
fix/adxl-build-warnings
branch
from
zephyrbot
requested review from
MaureenHelm,
asemjonovs,
avisconti,
galak,
jeppenodgaard,
microbuilder,
ozersa,
teburd,
tristan-google,
ttmut,
ubieda,
yasinustunerg and
yperess
Fix invalid pointer-to-integer cast and comparison warnings in ADXL362, ADXL367, and ADXL372 decoder drivers. The previous code used
(uint8_t *)*fitfor offset comparison, which triggered-Wint-to-pointer-castwarnings on recent compilers and could lead to undefined behavior.This patch replaces unsafe casts with
uintptr_tarithmetic and ensures type-safe offset calculations, preserving existing logic while eliminating all build warnings.