-
Notifications
You must be signed in to change notification settings - Fork 7.6k
soc: dts: drivers: add SoCs for amebad series #91933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 added project Note: This message is automatically posted and updated by the Manifest GitHub Action. |
# This option for code in modules/hal | ||
config AMEBAD | ||
bool | ||
default y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should check SOC_AMEBAD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if SOC_AMEBAD
in line 4 has already checked SOC_AMEBAD
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as in, whole symbol to go, your other code checking for this symbol needs to check for SOC_AMEBAD
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both "config AMEBAD" and "config ARM_CORE_CM4" are required by external modules, and I have already moved them into the Kconfig of the external module.
soc/realtek/ameba/amebad/Kconfig.soc
Outdated
config ARM_CORE_CM4 | ||
bool | ||
default y if SOC_AMEBAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be used by the code of external modules. Should I move this definition to the hal_realtek
repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is such a general Kconfig that it's possible it will clash and not only that doesn't even make sense given that it's selecting the m33 symbol then pretending to be an m4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both "config AMEBAD" and "config ARM_CORE_CM4" are required by external modules, and I have already moved them into the Kconfig of the external module.
Realtek HAL (Hardware Abstraction Layer) provides a low level peripheral configuration function. Signed-off-by: zjian zhang <[email protected]>
add initial version of devicetree for amebad SOC. amebad devicetree file is main platform dtsi file, which should be included from board dts (e.g rtl872xd_evb.dts) Signed-off-by: zjian zhang <[email protected]>
Add initial version of Amebad Soc integration Signed-off-by: zjian zhang <[email protected]>
add amebad pin controller driver Signed-off-by: zjian zhang <[email protected]>
loguart driver for amebad Signed-off-by: zjian zhang <[email protected]>
GPIO driver for amebad Signed-off-by: zjian zhang <[email protected]>
add initial version of rtl872xd_evb board Signed-off-by: zjian zhang <[email protected]>
This commit adds maintainers for hal_realtek repository Signed-off-by: zjian zhang <[email protected]>
|
The amebad microcontroller (MCU) is an advanced system-on-chip (SoC) featuring an Arm® Cortex®-M33 and Cortex®-M23, large Flash and SRAM memories, and supports dual-band Wi-Fi 4(2.4GHz + 5GHz) and BLE5.0 specifications.
The initial support for the board includes GPIO, PINCTRL and Loguart(serial).