wifi: Add support for runtime BSS max idle support configuration #91904
+176
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
jukkar,
krish2718,
MaochenWang1 and
rlubos
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hostap
DNM (manifest)
krish2718
reviewed
Jun 19, 2025
krish2718
reviewed
Jun 19, 2025
subsys/net/l2/wifi/wifi_shell.c
Outdated
| @@ -4285,6 +4311,12 @@ SHELL_SUBCMD_ADD((wifi), ps_exit_strategy, NULL, | |||
| cmd_wifi_ps_exit_strategy, | |||
| 2, 2); | |||
|
|
|||
| SHELL_SUBCMD_ADD((wifi), bss_max_idle_period, NULL, | |||
| "<bss_max_idle: timer(in TUs)>.\n" | |||
There was a problem hiding this comment.
Suggested change
| "<bss_max_idle: timer(in TUs)>.\n" | |
| "<bss_max_idle: timeout (in TUs)>.\n" |
ajayparida
force-pushed
the
bss_max_idle_timeout
branch
from
7e7c4cd to
a0d39e2
Compare
github-actions
bot
requested review from
anangl,
jaz1-nordic,
kl-cruz,
Kludentwo,
magp-nordic,
masz-nordic,
nika-nordic and
sachinthegreen
github-actions
bot
removed
manifest
manifest-hostap
DNM (manifest)
krish2718
changed the title
krish2718
reviewed
Jun 24, 2025
krish2718
reviewed
Jun 24, 2025
ajayparida
force-pushed
the
bss_max_idle_timeout
branch
from
a0d39e2 to
20dd740
Compare
github-actions
bot
added
manifest
manifest-hostap
DNM (manifest)
ajayparida
force-pushed
the
bss_max_idle_timeout
branch
2 times, most recently
from
1ecff80 to
1c1499f
Compare
Support to configure BSS max idle period at runtime. Signed-off-by: Ajay Parida <[email protected]>
Revert max idle period configuration from hostap. Signed-off-by: Ajay Parida <[email protected]>
ajayparida
force-pushed
the
bss_max_idle_timeout
branch
from
1c1499f to
61a16fd
Compare
|
sachinthegreen
approved these changes
Jun 24, 2025
krish2718
reviewed
Jun 24, 2025
| @@ -88,6 +88,8 @@ struct nrf_wifi_vif_ctx_zep { | |||
| struct k_work_delayable nrf_wifi_rpu_recovery_bringup_work; | |||
| #endif /* CONFIG_NRF_WIFI_RPU_RECOVERY */ | |||
| int rts_threshold_value; | |||
| bool bss_max_idle_period_user_set; | |||
There was a problem hiding this comment.
as this is just a once shot flag, do we really need it? We can just initialized bss_max_idle_period = -1 (which overflows as it's unsigned int and becomes invalid as valid is only 64000`?
| @@ -4285,6 +4311,12 @@ SHELL_SUBCMD_ADD((wifi), ps_exit_strategy, NULL, | |||
| cmd_wifi_ps_exit_strategy, | |||
| 2, 2); | |||
|
|
|||
| SHELL_SUBCMD_ADD((wifi), bss_max_idle_period, NULL, | |||
| "<bss_max_idle_period: timeout(in TUs)>.\n" | |||
There was a problem hiding this comment.
Suggested change
| "<bss_max_idle_period: timeout(in TUs)>.\n" | |
| "<BSS max idle period preference: timeout(in TUs)>.\n" |
| @@ -149,3 +149,19 @@ config HEAP_MEM_POOL_ADD_SIZE_WIFI_CERT | |||
| endif # WIFI_SHELL_RUNTIME_CERTIFICATES | |||
|
|
|||
| endif # WIFI_NM_WPA_SUPPLICANT_CRYPTO_ENTERPRISE | |||
|
|
|||
| config WIFI_MGMT_BSS_MAX_IDLE_TIME | |||
| int "BSS max idle timeout in seconds" | |||
There was a problem hiding this comment.
Suggested change
| int "BSS max idle timeout in seconds" | |
| int "BSS max idle timeout in TUs" |
Please confirm the units, shell says TUs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support to configure BSS max idle period at runtime.