drivers: wifi: siwx91x: Fix SLAAC other configuration issues #91465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interface was properly set "dormant" on disconnect. However on startup, it arrived in the system with "awake" status. Hence, some configuration frames were sent before the interface was connected. Then, when the interface was marked awake after the connection, the frames were not sent again since the operational mode did not changed. Therefore, Router Solicitations were not send, the Router Advertisements were not received and the IPv6 address was not set. Signed-off-by: Jérôme Pouiller <[email protected]>
github-actions
bot
requested review from
asmellby,
jhedberg,
jukkar,
Kludentwo,
krish2718,
MaochenWang1,
Martinhoff-maker and
rlubos
jerome-pouiller
requested review from
ArunmaniAlagarsamy2710
and removed request for
jhedberg,
jukkar,
Kludentwo,
asmellby,
rlubos,
Martinhoff-maker,
krish2718 and
MaochenWang1
ArunmaniAlagarsamy2710
approved these changes
Jun 12, 2025
jhedberg
previously approved these changes
Jun 12, 2025
asmellby
previously approved these changes
Jun 12, 2025
It seems there is no functional impact, but it makes sense to also update the state of the interface when AP is started/stopped. Signed-off-by: Jérôme Pouiller <[email protected]>
github-actions
bot
requested review from
krish2718,
MaochenWang1,
Martinhoff-maker and
rlubos
|
v2:
|
drivers/wifi/siwx91x/siwx91x_wifi.c
Outdated
| @@ -854,6 +854,7 @@ static int siwx91x_ap_enable(const struct device *dev, struct wifi_connect_req_p | |||
| if (IS_ENABLED(CONFIG_WIFI_SILABS_SIWX91X_NET_STACK_NATIVE)) { | |||
| net_if_dormant_off(sidev->iface); | |||
| } | |||
| wifi_mgmt_raise_ap_enable_result_event(sidev->iface, WIFI_STATUS_AP_SUCCESS); | |||
There was a problem hiding this comment.
I suggest we skip raising the event here, as siwx91x_wifi_module_stats_event_handler already handles the AP success event
There was a problem hiding this comment.
Indeed, I was surprised to find a such issue.
jerome-pouiller
force-pushed
the
fix-slaac
branch
from
359dd3f to
15624a7
Compare
|
jhedberg
approved these changes
Jun 12, 2025
jukkar
approved these changes
Jun 12, 2025
asmellby
approved these changes
Jun 13, 2025
dkalowsk
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface was properly set "dormant" on disconnect. However on startup, it arrived in the system with "awake" status. Hence, some configuration frames were sent before the interface was connected. Then, when the interface was marked awake after the connection, the frames were not sent again since the operational mode did not changed.
Therefore, Router Solicitations were not send, the Router Advertisements were not received and the IPv6 address was not set.