modules: hal_nordic: nrf_802154: CCA threshold config in dBm + nRF54L15 clock latency #90795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_nordic
DNM (manifest)
ankuns
previously approved these changes
May 29, 2025
e-rk
changed the title
github-actions
bot
requested review from
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
ankuns
reviewed
Jun 11, 2025
| @@ -18,7 +18,11 @@ static bool hfclk_is_running; | |||
|
|
|||
| void nrf_802154_clock_init(void) | |||
| { | |||
| /* Intentionally empty. */ | |||
| #ifdef NRF54L_SERIES | |||
| uint32_t clock_latency_us = z_nrf_clock_bt_ctlr_hf_get_startup_time_us(); | |||
There was a problem hiding this comment.
I'm just curious. Is there a reason to not do
#if DT_NODE_EXISTS(DT_NODELABEL(hfxo))
uint32_t clock_latency_us = DT_PROP(DT_NODELABEL(hfxo), startup_time_us);
nrf_802154_clock_hfclk_latency_set(clock_latency_us);
#endif?
If you prefer to call z_nrf_clock_bt_ctlr_hf_get_startup_time_us, note it is wrapped with
#if DT_NODE_EXISTS(DT_NODELABEL(hfxo))
https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/clock_control/clock_control_nrf.c#L440
There was a problem hiding this comment.
The property is marked as required on nordic,nrf54l-hfxo binding. If there is no such property, the build will fail due to missing property.
ankuns
previously approved these changes
Jun 11, 2025
anangl
previously approved these changes
Jun 18, 2025
ankuns
previously approved these changes
Jun 18, 2025
The new hal_nordic revision brings changes in nrf-802154 component related to CCA threshold configuration. The CCA threshold configuration is now done in dBm units. Signed-off-by: Rafał Kuźnia <[email protected]>
The nrf-802154 component of hal_nordic is updated. The CCA threshold configuration is now done in dBm units, instead of hardware-dependent scale. Fixed a bug, where the CONFIG_NRF_802154_CCA_ED_THRESHOLD units were different from the NRF_802154_CCA_ED_THRESHOLD units. Now all configuration is done in dBm. Signed-off-by: Rafał Kuźnia <[email protected]>
The HFXO used on nRF54L15 DK has the typical startup latency of 854us. Signed-off-by: Rafał Kuźnia <[email protected]>
The clock startup latency is now obtained from the clock driver and the nrf-802154 is now set to a value that matches hardware capabilities. Signed-off-by: Rafał Kuźnia <[email protected]>
github-actions
bot
removed
the
DNM (manifest)
anangl
approved these changes
Jun 18, 2025
|
ankuns
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nrf-802154 component of hal_nordic is updated. The CCA threshold configuration is now done in dBm units, instead of hardware-dependent scale.
Fixed a bug, where the CONFIG_NRF_802154_CCA_ED_THRESHOLD units were different from the NRF_802154_CCA_ED_THRESHOLD units. Now all configuration is done in dBm.
Addidtionally, added clock latency configuration and a more optimized HFXO startup time for nRF54L15 DK.