Remove socketpair in hostap to save memory #90317

jukkar · 2025-05-22T08:26:05Z

Replace wifi event mechanism by k_fifo. Earlier we had socketpair to pass wifi event information from wpa_supplicant side to zephyr adaption layer. This is now replaced by k_fifo to save some RAM.

github-actions · 2025-05-22T09:08:04Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hostap	zephyrproject-rtos/hostap@`cf27000` (`main`)	zephyrproject-rtos/hostap#86	zephyrproject-rtos/hostap#86/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

jukkar · 2025-05-23T12:42:46Z

Updated hostap repo with hostapd (AP) support

jukkar · 2025-05-23T12:46:06Z

See information about memory savings in zephyrproject-rtos/hostap#86

jukkar · 2025-05-23T12:47:31Z

Needs more testing and review so adding DNM label.

cfriedt

That's some really fantastic memory savings!

jukkar · 2025-06-09T09:43:36Z

@MaochenWang1 can you take a look to changes too. I have used frdm-rw612 when testing this and everything seems to work ok, but if you have some automated test system, it would be nice to get results from it too.

MaochenWang1 · 2025-06-10T03:43:26Z

@MaochenWang1 can you take a look to changes too. I have used frdm-rw612 when testing this and everything seems to work ok, but if you have some automated test system, it would be nice to get results from it too.

Hi @jukkar thanks for your work.
But I test the TOT of upstream with your change on RW612 (also apply #89294 to fix build error), the STA connection to OPEN/WPA3 AP is not successful,
For OPEN mode, it seems DHCP is not triggered.

For WPA3 mode, the 4-way handshake is not successful, as DUT didn't send 2/4 key.

I also tried the image without your change, STA connection to OPEN/WPA3 AP is Okay.

My build cmd:
west build -p always -b rd_rw612_bga samples/net/wifi/shell -DEXTRA_CONF_FILE="nxp/overlay_rw612.conf nxp/overlay_hostap_rw612.conf"

Did you verify the connection on Frdm_RW612 board?

jukkar · 2025-06-10T06:33:42Z

I could connect to WPA2 and WPA3 AP without issues using frdm_rw612 board.

west build -p -d ~/zephyrproject/build/wifi-shell \
  ~/zephyrproject/zephyr/samples/net/wifi/shell/ -b frdm_rw612 -S wifi-ip -- \
 -DCONFIG_NET_DHCPV4=y -DCONFIG_NET_CONFIG_SETTINGS=n -DCONFIG_NET_HOSTNAME_ENABLE=y

I did not had #89294 applied. My hal_nxp is at e0b43431640a565b4500c58fc5e1aaebec2f463d

carlescufi · 2025-06-23T11:07:58Z

@MaochenWang1 please review

Remove Kconfig dependency to socketpair related options as the hostap now uses k_fifo to pass information between different threads. Signed-off-by: Jukka Rissanen <[email protected]>

Earlier we had socketpair to pass wifi event information from wpa_supplicant side to zephyr adaption layer. This is now replaced by k_fifo to save some RAM. Signed-off-by: Jukka Rissanen <[email protected]>

Make sure to use k_fifo for IPC in hostap to save memory. Signed-off-by: Jukka Rissanen <[email protected]>

hostap needs more eventfd to function so set a proper default value. Signed-off-by: Jukka Rissanen <[email protected]>

jukkar · 2025-06-25T07:25:33Z

No code changes, rebased to latest main to get rid of merge conflict in west.yml

sonarqubecloud · 2025-06-25T07:28:21Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jukkar requested review from rlubos, krish2718 and MaochenWang1 May 22, 2025 08:26

github-actions bot added manifest manifest-hostap DNM (manifest) This PR should not be merged (controlled by action-manifest) labels May 22, 2025

jukkar changed the title ~~[WIP] Remove socketpair in hostap to save memory~~ Remove socketpair in hostap to save memory May 23, 2025

jukkar force-pushed the devel/remove-socketpair-in-hostap branch from 37f990d to 15b13be Compare May 23, 2025 12:41

jukkar marked this pull request as ready for review May 23, 2025 12:41

github-actions bot added area: Networking area: POSIX POSIX API Library area: Sockets Networking sockets labels May 23, 2025

github-actions bot added the area: Wi-Fi Wi-Fi label May 23, 2025

github-actions bot requested review from cfriedt, pdgendt, ssharks and ycsin May 23, 2025 12:42

github-actions bot assigned rlubos May 23, 2025

jukkar assigned krish2718 and unassigned rlubos May 23, 2025

jukkar added the DNM This PR should not be merged (Do Not Merge) label May 23, 2025

cfriedt previously approved these changes May 24, 2025

View reviewed changes

jukkar dismissed cfriedt’s stale review via 636e8df May 26, 2025 14:51

jukkar force-pushed the devel/remove-socketpair-in-hostap branch from 636e8df to ba7a5c8 Compare May 26, 2025 15:25

jukkar force-pushed the devel/remove-socketpair-in-hostap branch from ba7a5c8 to 099179d Compare June 3, 2025 07:31

jukkar removed the DNM This PR should not be merged (Do Not Merge) label Jun 3, 2025

github-actions bot requested review from jeremybettis, nashif, nordicjm and tejlmand June 4, 2025 07:54

github-actions bot added the area: Samples Samples label Jun 5, 2025

github-actions bot requested a review from kartben June 5, 2025 07:05

cfriedt previously approved these changes Jun 5, 2025

View reviewed changes

jukkar dismissed cfriedt’s stale review via cb11687 June 6, 2025 15:04

jukkar force-pushed the devel/remove-socketpair-in-hostap branch from e3f730b to cb11687 Compare June 6, 2025 15:04

github-actions bot added the area: Base OS Base OS Library (lib/os) label Jun 6, 2025

github-actions bot requested review from andyross and dcpleung June 6, 2025 15:05

jukkar force-pushed the devel/remove-socketpair-in-hostap branch from cb11687 to e0805fa Compare June 9, 2025 06:30

krish2718 previously approved these changes Jun 9, 2025

View reviewed changes

cfriedt previously approved these changes Jun 10, 2025

View reviewed changes

krish2718 mentioned this pull request Jun 20, 2025

drivers: wifi: nrf7002: Add support for multiple virtual interfaces #91916

Open

krish2718 mentioned this pull request Jun 24, 2025

zephyr: Use k_fifo instead of socketpair for IPC zephyrproject-rtos/hostap#86

Open

jukkar added 4 commits June 25, 2025 10:24

hostap: Remove dependency to socketpair

265fb18

Remove Kconfig dependency to socketpair related options as the hostap now uses k_fifo to pass information between different threads. Signed-off-by: Jukka Rissanen <[email protected]>

hostap: Replace wifi event mechanism by k_fifo

e8db4fe

Earlier we had socketpair to pass wifi event information from wpa_supplicant side to zephyr adaption layer. This is now replaced by k_fifo to save some RAM. Signed-off-by: Jukka Rissanen <[email protected]>

manifest: Use k_fifo for IPC in hostap

c291596

Make sure to use k_fifo for IPC in hostap to save memory. Signed-off-by: Jukka Rissanen <[email protected]>

lib: zvfs: Add default eventfd count for hostap

28ee112

hostap needs more eventfd to function so set a proper default value. Signed-off-by: Jukka Rissanen <[email protected]>

jukkar dismissed stale reviews from cfriedt and krish2718 via 28ee112 June 25, 2025 07:24

jukkar force-pushed the devel/remove-socketpair-in-hostap branch from e0805fa to 28ee112 Compare June 25, 2025 07:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove socketpair in hostap to save memory #90317

Remove socketpair in hostap to save memory #90317

jukkar commented May 22, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 22, 2025 •

edited

Loading

Uh oh!

jukkar commented May 23, 2025

Uh oh!

jukkar commented May 23, 2025

Uh oh!

jukkar commented May 23, 2025

Uh oh!

cfriedt left a comment

Uh oh!

jukkar commented Jun 9, 2025

Uh oh!

MaochenWang1 commented Jun 10, 2025

Uh oh!

jukkar commented Jun 10, 2025

Uh oh!

carlescufi commented Jun 23, 2025

Uh oh!

jukkar commented Jun 25, 2025

Uh oh!

sonarqubecloud bot commented Jun 25, 2025

Uh oh!

Uh oh!

Remove socketpair in hostap to save memory #90317

Are you sure you want to change the base?

Remove socketpair in hostap to save memory #90317

Conversation

jukkar commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jukkar commented May 23, 2025

Uh oh!

jukkar commented May 23, 2025

Uh oh!

jukkar commented May 23, 2025

Uh oh!

cfriedt left a comment

Choose a reason for hiding this comment

Uh oh!

jukkar commented Jun 9, 2025

Uh oh!

MaochenWang1 commented Jun 10, 2025

Uh oh!

jukkar commented Jun 10, 2025

Uh oh!

carlescufi commented Jun 23, 2025

Uh oh!

jukkar commented Jun 25, 2025

Uh oh!

sonarqubecloud bot commented Jun 25, 2025

Quality Gate passed

Uh oh!

Uh oh!

jukkar commented May 22, 2025 •

edited

Loading

github-actions bot commented May 22, 2025 •

edited

Loading