-
Notifications
You must be signed in to change notification settings - Fork 46
wifi: winc1500: Update HAL version to 19.7.6 #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @lromeraj , Change is fine for me but you need to follow PR rules here as in Zephyr. See README in this repo. |
Hi @nandojve, Thanks! I will also create the corresponding PR in the Zephyr repository. I’m currently updating the HAL (aka host_drv) to version 19.7.6, which I downloaded here. This version introduces new features and fixes, and it requires some modifications on the Zephyr side as well—but I already have a working version. I understand that a PR in the Zephyr repository is needed too. Do you think it makes sense to include the HAL update in this PR, or would you prefer a separate PR for the new HAL version? |
Yes, I particularly never saw the module working and I would like to have it. Then open the correspondent PR in Zephyr with the bump + changes. Pay attention to no break bisect in Zephyr repo. So, if the bump requires at same time the changes in Zephyr you need to make sure add in the same commit. We care about bisect that allow us to build and don't break other platforms. |
Hi @lromeraj , No worries, take your time! |
Hi @nandojve, I’d like to change the source branch because I realized I created the pull request from |
I don't think this is a problem because it is your main branch. |
@nandojve Sorry, I completely missed that. I’ll push the changes to the master branch instead. |
@nandojve I’d like to propose an idea: since the WINC1500 supports OTA updates, it would be useful to upload the corresponding binary to a location in this repository. This way, we could set a default URL in the Kconfig pointing to the binary, making the download and update process straightforward. What do you think? Perhaps we could use GitHub Pages or another method to make the file publicly accessible. |
Hi @lromeraj , There is a specific rules about blobs in the docs. I'll ask you to read those sections. |
@nandojve I see. Uploading the binary elsewhere doesn’t feel safe to me. I’d prefer keeping it in the repository so we have full control over modifications and updates. |
@nandojve Regarding the required HAL modifications: I’m using the
Several core socket functions (e.g., |
Rename the configuration symbol in
nm_bsp_internal.h
fromCONFIG_WIFI_WINC1500
toCONFIG_ATMEL_WINC1500
to decouple the BSP header inclusion from the default Zephyr driver.This change allows alternative driver implementations to use the BSP headers without being forced to enable
CONFIG_WIFI_WINC1500
, which otherwise enables the built-in Zephyr driver and can cause conflicts when providing a custom driver.