Skip to content

Add missing override keywords to hopefully fix CI #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zenorogue merged 1 commit into from
Feb 22, 2026
Merged

Add missing override keywords to hopefully fix CI #499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rogueviz/embeddings/compare.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ struct dmercator_embedding : abstract_embedding {
virtual string name() override { return "dmercator"; }
eGeometryClass get_geometry() override { return gcHyperbolic; }
int get_dimension() override { return 3; }
hyperpoint as_hyperpoint(int id) {
hyperpoint as_hyperpoint(int id) override {
auto& mc = mcs[id];
hyperpoint h;
for(int i=0; i<3; i++)
Expand All @@ -175,7 +175,7 @@ struct dmercator_embedding : abstract_embedding {

ld zero_distance(int id) override { return mcs[id].distance; }

ld distance(int a, int b) {
ld distance(int a, int b) override {
if(a == b) return ld(0);
ld da = mcs[a].distance;
ld db = mcs[b].distance;
Expand Down