Merged
Conversation
- Detect when JAVA_HOME or java executable points to asdf shims directory - Use 'asdf which java' to resolve shims to actual Java installation - Add support for SDKMAN Java installations - Properly infer JAVA_HOME from resolved paths - Fixes services failing with "JAVA_HOME not defined correctly" when using asdf This resolves the issue where Vertex inherited JAVA_HOME pointing to /.asdf/shims instead of the actual Java installation path like /.asdf/installs/java/openjdk-21, causing Maven and Gradle wrappers to fail.
- Allow services to override JAVA_HOME via service-specific environment variables - Service-level JAVA_HOME takes precedence over profile-level Java override - Automatically update PATH when service sets custom JAVA_HOME - Environment variable precedence: Service > Profile > Global This enables running services with different Java versions within the same profile by setting JAVA_HOME in each service's environment variables. Example usage: - Service A: JAVA_HOME=/Users/user/.asdf/installs/java/openjdk-21 - Service B: JAVA_HOME=/Users/user/.asdf/installs/java/openjdk-17
- Add logJavaVersion helper function to detect and display Java version - Show Java version, source (asdf/sdkman/system), and JAVA_HOME path - Log information at service startup for easy debugging - Helps verify per-service Java version override is working correctly Example log output: [INFO] Service EUREKA: Using Java 21.0.1 from asdf (/Users/user/.asdf/installs/java/openjdk-21) [INFO] Service LEGACY: Using Java 17.0.5 from asdf (/Users/user/.asdf/installs/java/openjdk-17)
Backend changes: - Add VerboseLogging boolean field to Service model - Add verbose_logging column to services database table with migration - Update GetStartCommand to add verbose flags when enabled: * Maven: adds -X flag for debug output * Gradle: adds -i flag for info level logging - Update all database queries to include verbose_logging field Frontend changes: - Add verboseLogging field to Service TypeScript interface - Add checkbox in ServiceConfigModal for toggling verbose logging - Include helpful label: "Enable verbose logging (Maven: -X, Gradle: -i)" - Initialize verboseLogging to false for new services This feature helps debug build and startup issues by providing more detailed logging output from Maven and Gradle build tools when enabled on a per-service basis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.