ZIP 400: Update wallet schema #968
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daira
reviewed
Jan 8, 2025
daira
reviewed
Jan 8, 2025
zips/zip-0400.rst
Outdated
|
|
||
| "acc*", "Account data", "1. ``string strAccount``", "1. ``CAccount account``" | ||
| "acentry*", "Track internal transfers between accounts in the same wallet", "1. ``string strAccount`` | ||
| "3..4", "acc*", "Account data", "1. ``string strAccount``", "1. ``CAccount account``" |
Collaborator
There was a problem hiding this comment.
If the end version is less than 6:
- Check this is actually correct.
- If it is, describe how later versions handle/migrate the key.
Author
There was a problem hiding this comment.
Looks like both acc and acentry, which were part of the 'account' API, were disabled since the Zcash launch, and removed in v4.5.0: https://github.com/zcash/zcash/releases/tag/v4.5.0.
Here is also the Bitcoin Core release it references: https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.17.0.md#label-and-account-apis-for-wallet.
Should we add the fact that both were deprecated/disabled, and that they have no replacement?
Co-authored-by: Daira-Emma Hopwood <[email protected]>
…r `chdseed` & `hdseed` and add instancing details.
daira
reviewed
Feb 22, 2025
daira
reviewed
Feb 22, 2025
daira
reviewed
Feb 22, 2025
daira
reviewed
Feb 22, 2025
daira
reviewed
Feb 22, 2025
daira
reviewed
Feb 22, 2025
daira
reviewed
Feb 22, 2025
daira
reviewed
Feb 22, 2025
daira
reviewed
Feb 22, 2025
Co-authored-by: Daira-Emma Hopwood <[email protected]>
Co-authored-by: Daira-Emma Hopwood <[email protected]>
Co-authored-by: Daira-Emma Hopwood <[email protected]>
Co-authored-by: Daira-Emma Hopwood <[email protected]>
`acc` and `acentry` were inherited from Bitcoin’s accounts API, but were disabled from Zcash’s inception and removed in v4.5.0. They have no replacement and were never used in Zcash wallets. Co-authored-by: Daira-Emma Hopwood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #964. This PR updates the wallet schema to incorporate all changes across different
zcashdversions.