Repository navigation
Conversation
Signed-off-by: curlwget <curlwget@icloud.com>
Collaborator
|
Thanks — both comments were stale, and #526 reported the This PR conflicts with master, so rather than ask for a rebase I've fixed both in one commit and credited both reports. The Closing in favor of that commit. |
emersonian
pushed a commit
to zecrocks/lightwalletd
that referenced
this pull request
Aug 29, 2026
Both comments named a function other than the one they document, so `go doc` and every editor that reads doc comments attributed them to nothing. `GetTaddressTransactions` was still documented as `GetTaddressTxids`, the name it carried before 8c4c83a split the deprecated RPC out into its own wrapper. Its "NB, this method is misnamed" note goes away with the rename: it described `GetTaddressTxids`, which is still deprecated, still present, and still carries that explanation in full -- along with a link to zcash#426 -- on the wrapper 90 lines below. `addBlockActive` was documented as `DarksideAddBlock`, a name that no longer exists anywhere in the tree. Reported in zcash#524 and zcash#526. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015DeK7pepamvANHSUUZWBpm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix some function names in comment