Reduce usage of error level logging in ascan rules #6644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thc202
changed the title
|
Great job! No new security vulnerabilities introduced in this pull request |
kingthorin
force-pushed
the
dont-log-at-error
branch
from
1177681 to
231a33d
Compare
kingthorin
commented
Aug 6, 2025
| @@ -382,7 +382,7 @@ private void sendPayloadsToMakeCallBack(String paramName, String[] commandExecPa | |||
| ex.getMessage(), | |||
| msg.getRequestHeader().getURI()); | |||
| } catch (IOException ex) { | |||
There was a problem hiding this comment.
Exception is also caught just below, shall I remove that catch clause?
kingthorin
commented
Aug 6, 2025
| @@ -156,7 +156,7 @@ public void scan(HttpMessage msg, String param, String value) { | |||
| scanWithPayloads(param, ATTACK_PATTERNS_CVE44228, PREFIX_CVE44228); | |||
| scanWithPayloads(param, ATTACK_PATTERNS_CVE45046, PREFIX_CVE45046); | |||
| } catch (Exception e) { | |||
| LOGGER.error(e.getMessage(), e); | |||
| LOGGER.warn(e.getMessage(), e); | |||
kingthorin
commented
Aug 6, 2025
There was a problem hiding this comment.
This may be too much change, I'm happy to revert this file if wanted.
kingthorin
force-pushed
the
dont-log-at-error
branch
4 times, most recently
from
5c23602 to
0380908
Compare
kingthorin
force-pushed
the
dont-log-at-error
branch
from
0380908 to
815e1c2
Compare
- Add change note. - Update logging in scan rules. Signed-off-by: kingthorin <[email protected]> # Conflicts: # addOns/ascanrules/CHANGELOG.md
kingthorin
force-pushed
the
dont-log-at-error
branch
from
815e1c2 to
1d5b721
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview