Skip to content

Conversation

kingthorin
Copy link
Member

@kingthorin kingthorin commented Jul 4, 2025

Overview

The SQL Injection Oracle scan rule has been renamed to indicate that it currently only does time based tests (Issue 7341). (The help already indicates that it is time based).

Related Issues

@psiinon
Copy link
Member

psiinon commented Jul 4, 2025

Logo
Checkmarx One – Scan Summary & Details7ae79a91-3d30-442d-b022-3873cb81ca91

Great job, no security vulnerabilities found in this Pull Request

@kingthorin kingthorin force-pushed the sqli-oracle-split branch from 409db5a to 5cbf188 Compare July 7, 2025 16:49
@kingthorin kingthorin changed the title ascanrules: SQLi Oracle rename scan rule (all timing based) ascanrules: SQLi Oracle rename scan rule (all time based) Jul 15, 2025
@kingthorin kingthorin force-pushed the sqli-oracle-split branch 2 times, most recently from 7af2916 to fb57dce Compare July 15, 2025 14:07
@thc202
Copy link
Member

thc202 commented Jul 15, 2025

Since the rule is now time specific we could drop the other do* variables (and errors map?).

@kingthorin
Copy link
Member Author

Done

@thc202
Copy link
Member

thc202 commented Jul 15, 2025

Sorry, doTimeBased could go as well and the map if you agree for all time rules.

@kingthorin kingthorin force-pushed the sqli-oracle-split branch 2 times, most recently from 5c7757a to 33512a4 Compare July 15, 2025 16:03
@kingthorin
Copy link
Member Author

Agreed. Done here. Will make another pass 😀

@kingthorin
Copy link
Member Author

Should be good across others now too.

@thc202
Copy link
Member

thc202 commented Jul 15, 2025

Just noticed the changelog entry is in Added instead of Changed like the other ones (there will be conflicts).

@kingthorin
Copy link
Member Author

Fixed, and will try to address them as things are merged.

@thc202
Copy link
Member

thc202 commented Jul 16, 2025

Thank you!

@thc202 thc202 requested a review from psiinon July 16, 2025 09:41
@thc202 thc202 merged commit c42bfda into zaproxy:main Jul 16, 2025
8 of 9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2025
@kingthorin kingthorin deleted the sqli-oracle-split branch July 16, 2025 10:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants