ascanrules: CMDi split timing tests to new scan rule #6551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
kingthorin
force-pushed
the
cmdi-split
branch
2 times, most recently
from
015bdee to
faa12c1
Compare
|
I believe this is ready for review. |
kingthorin
force-pushed
the
cmdi-split
branch
2 times, most recently
from
208b798 to
cfb4ce9
Compare
thc202
reviewed
Jul 18, 2025
.../ascanrules/src/main/java/org/zaproxy/zap/extension/ascanrules/CommandInjectionScanRule.java
Outdated
Show resolved
Hide resolved
...rules/src/main/java/org/zaproxy/zap/extension/ascanrules/CommandInjectionTimingScanRule.java
Outdated
Show resolved
Hide resolved
...rules/src/main/java/org/zaproxy/zap/extension/ascanrules/CommandInjectionTimingScanRule.java
Outdated
Show resolved
Hide resolved
...c/main/javahelp/org/zaproxy/zap/extension/ascanrules/resources/help/contents/ascanrules.html
Outdated
Show resolved
Hide resolved
...c/test/java/org/zaproxy/zap/extension/ascanrules/CommandInjectionTimingScanRuleUnitTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/zaproxy/zap/extension/ascanrules/CommandInjectionTimingScanRuleUnitTest.java
Show resolved
Hide resolved
|
Got all those (I hope). |
thc202
reviewed
Jul 18, 2025
...rules/src/main/java/org/zaproxy/zap/extension/ascanrules/CommandInjectionTimingScanRule.java
Outdated
Show resolved
Hide resolved
Signed-off-by: kingthorin <[email protected]>
|
Done |
thc202
approved these changes
Jul 18, 2025
|
Thank you! |
There was a problem hiding this comment.
Pull Request Overview
This PR separates the Command Injection scan rule into two distinct scan rules: one feedback-based (retaining ID 90020) and one time-based (assigned new ID 90037). The separation removes timing attack functionality from the original rule and creates a dedicated timing-based rule for better organization and testing coverage.
- Time-based command injection functionality moved to new
CommandInjectionTimingScanRulewith ID 90037 - Original
CommandInjectionScanRuleretained as feedback-based only, keeping ID 90020 - Common test functionality extracted to shared base class
CommandInjectionRuleTest
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| CommandInjectionTimingScanRule.java | New time-based command injection scan rule implementation |
| CommandInjectionTimingScanRuleUnitTest.java | Unit tests for the new timing-based scan rule |
| CommandInjectionScanRule.java | Refactored to remove timing functionality, keeping only feedback-based detection |
| CommandInjectionScanRuleUnitTest.java | Updated tests with timing-related functionality removed |
| CommandInjectionRuleTest.java | New abstract base class for shared command injection test functionality |
| Messages.properties | Updated message keys to separate feedback and time-based descriptions |
| ascanrules.html | Updated help documentation to describe the two separate rules |
| CHANGELOG.md | Documented the rule separation |
Comments suppressed due to low confidence (1)
addOns/ascanrules/src/main/javahelp/org/zaproxy/zap/extension/ascanrules/resources/help/contents/ascanrules.html:81
- The filename 'CommandInjectionScaRule.java' appears to be a typo. It should be 'CommandInjectionScanRule.java' based on the actual class name.
Latest code: <a href="https://github.com/zaproxy/zap-extensions/blob/main/addOns/ascanrules/src/main/java/org/zaproxy/zap/extension/ascanrules/CommandInjectionTimingScanRule.java">CommandInjectionTimingScanRule.java</a>
psiinon
approved these changes
Jul 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The Remote OS Command Injection scan rule has been broken into two rules; one feedback based, and one time based (Issue 7341). This includes assigning the timing rule ID 90037, and updating the add-on's help content.
Related Issues