Open
Conversation
Implements src/docproc/vision.py that converts PDF pages to images using PyMuPDF locally, sends base64-encoded images to DeepFellow's OpenAI-compatible chat completions endpoint, and returns VisionResult. Closes #9
- Wrap PDF page rendering errors in VisionError (was propagating raw) - Add test for connection error exhausting all retries - Add test for image file read failure (OSError) - Add test for PDF rendering failure with doc.close() guarantee
- Raise VisionError on empty choices list instead of IndexError - Log warning when Vision API returns None/empty content - Add tests for both edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/docproc/vision.py— async Vision extraction via DeepFellow OpenAI-compatible APIAsyncOpenAIchat completionsVisionResultwith extracted markdown contentTest plan
Closes #9